Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Require go 1.23 for build #8597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Using the latest golang version for building CRI-O main.

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Require go 1.23 to build CRI-O.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 12, 2024
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@saschagrunert
Copy link
Member Author

/retest

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.87%. Comparing base (548e070) to head (b397159).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8597      +/-   ##
==========================================
- Coverage   48.88%   48.87%   -0.01%     
==========================================
  Files         153      153              
  Lines       17372    17372              
==========================================
- Hits         8492     8491       -1     
- Misses       7815     7816       +1     
  Partials     1065     1065              

@saschagrunert
Copy link
Member Author

/retest

Signed-off-by: Sascha Grunert <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 13, 2024

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn b397159 link true /test e2e-gcp-ovn
ci/prow/images b397159 link true /test images
ci/prow/ci-fedora-integration b397159 link true /test ci-fedora-integration
ci/prow/ci-fedora-kata b397159 link true /test ci-fedora-kata
ci/prow/ci-fedora-critest b397159 link true /test ci-fedora-critest
ci/prow/ci-cgroupv2-integration b397159 link true /test ci-cgroupv2-integration
ci/prow/e2e-aws-ovn b397159 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant