replace usages of snprintf, sscanf #179
Conversation
Mrmaxmeier
force-pushed
the
cleanup-shims
branch
2 times, most recently
from
71b826a
to
83a02e5
Compare
|
Maybe it’s a good idea to add some tests for the version parser? It looks better but it’s hard to tell from just looking. Would help if you wanted to change it to nom later as well. |
|
I like these changes, but not sure about Same also with |
Mrmaxmeier
force-pushed
the
cleanup-shims
branch
from
226a65f
to
533a538
Compare
|
If it is already in master, I'm not against. |
|
Personally i think |
|
Doesn’t every c2rust-generated “0 as *const _” have a corresponding explicit type annotation anyway, even in method bodies? I have been keeping the annotation but replacing the 0 with ptr::null. |
|
Seems good. Just need to fix compile errors on Mac (seems extern types doesn't work well together with ptr::null()?) and Windows (are we still calling vsprintf from somewhere?), and we're good to go~ |
Mrmaxmeier
force-pushed
the
cleanup-shims
branch
from
0b2868c
to
aadbe09
Compare
fastmod -m -d . --extensions rs \
"(tt_get_positive_quad\(\s+.+?,\s+)b(\".*?)\\\\x00.*?,(\s+)b(\".*?)\\\\x00.*?," \
"\${1}\${2}\",\${3}\${4}\","
fastmod -m -d . --extensions rs \
"pdf_add_stream\(\s*([^\n]*?),\s+?b(\".*?)\\\\x00\".*?,\s+.*?\)"
"pdf_add_stream_str(\${1}, \${2}\")"
This allows for exotic PDF with this header: 00000000: 2550 4446 2d31 2e34 204d 6172 7665 6c6c %PDF-1.4 Marvell 00000010: 2053 656d 6963 6f6e 6475 6374 6f72 0a31 Semiconductor.1
With checked (i32) adds, this panicked during format generation.
Mrmaxmeier
force-pushed
the
cleanup-shims
branch
from
aadbe09
to
d1858b6
Compare
This closes #192