Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new thumbv7neon_linux_androideabi and thumbv7neon-unknown-linux-gnueabihf targets #254

Closed
briansmith opened this issue Jan 26, 2019 · 0 comments · Fixed by #745
Closed

Comments

@briansmith
Copy link
Contributor

briansmith commented Jan 26, 2019

Originally Rust's armv7- targets hard-coded NEON support. However, that was changed in rust-lang/rust#47765.

rust-lang/rust#49897 tracks adding new thumbv7neon- targets that act like the old targets. See also the PR rust-lang/rust#56947 that adds them.

These targets are very useful since a lot of the time we know that NEON is going to be available on the target. The Rust issue above notes "Firefox opts not to support ARMv7 devices that don't have it," for example. I've also had people ask for versions of my software that assume NEON is available.

Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 2, 2022
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 3, 2022
Add the `thumbv7neon-linux-androideabi`, `thumbv7neon-unknown-linux-gnueabihf`, and `thumbv7neon-unknown-linux-musleabihf` targets.

Cloes cross-rs#254.
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 3, 2022
Add the `thumbv7neon-linux-androideabi`, `thumbv7neon-unknown-linux-gnueabihf`, and `thumbv7neon-unknown-linux-musleabihf` targets.

Cloes cross-rs#254.
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 3, 2022
Add the `thumbv7neon-linux-androideabi`, `thumbv7neon-unknown-linux-gnueabihf`, and `thumbv7neon-unknown-linux-musleabihf` targets.

Closes cross-rs#254.
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 3, 2022
Add the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.

Closes cross-rs#254.
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 3, 2022
Add the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.

Closes cross-rs#254.
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 8, 2022
Add the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.

Closes cross-rs#254.
bors bot added a commit that referenced this issue Jun 8, 2022
745: Add `thumbv7neon-*` targets. r=otavio a=Alexhuszagh

Add the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.
    
Closes #254.

746: Limit permissions for Android images. r=otavio,emilgardis a=Alexhuszagh

Remove the use of the `--privileged` flag for Android images and instead use an seccomp permissions. The provided profile is derived from the docker documentation, with slight modifications to allow `clone` and `clone3`.

The documentation is [docker seccomp](https://docs.docker.com/engine/security/seccomp/#significant-syscalls-blocked-by-the-default-profile), which details the syscalls blocked by docker. The same is true for podman. We merely modified these settings to allow `personality` syscall, which then allows us to use our Android images.

Co-authored-by: Alex Huszagh <[email protected]>
bors bot added a commit that referenced this issue Jun 8, 2022
745: Add `thumbv7neon-*` targets. r=Otavio a=Alexhuszagh

Add the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.
    
Closes #254.

746: Limit permissions for Android images. r=otavio,emilgardis a=Alexhuszagh

Remove the use of the `--privileged` flag for Android images and instead use an seccomp permissions. The provided profile is derived from the docker documentation, with slight modifications to allow `clone` and `clone3`.

The documentation is [docker seccomp](https://docs.docker.com/engine/security/seccomp/#significant-syscalls-blocked-by-the-default-profile), which details the syscalls blocked by docker. The same is true for podman. We merely modified these settings to allow `personality` syscall, which then allows us to use our Android images.

Co-authored-by: Alex Huszagh <[email protected]>
@bors bors bot closed this as completed in 2d2b5d3 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants