Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically define PKG_CONFIG_ALLOW_CROSS #383

Closed
gdesmott opened this issue Mar 5, 2020 · 2 comments · Fixed by #386
Closed

Automatically define PKG_CONFIG_ALLOW_CROSS #383

gdesmott opened this issue Mar 5, 2020 · 2 comments · Fixed by #386
Labels
container-images feature-request

Comments

@gdesmott
Copy link
Contributor

gdesmott commented Mar 5, 2020

Various crates requires env variable PKG_CONFIG_ALLOW_CROSS to be defined when being cross-compiled. Maybe cross should automatically set it to ease users' experience?
@reitermarkus
Copy link
Member

@gdesmott, can you submit a PR for this? Thanks!

@gdesmott gdesmott mentioned this issue Mar 6, 2020
Merged
@gdesmott
Copy link
Contributor Author

gdesmott commented Mar 6, 2020

@reitermarkus : here we go: #386

bors bot added a commit that referenced this issue Mar 6, 2020
@bors
Merge #386
2aa8990 
386: docker: define PKG_CONFIG_ALLOW_CROSS r=reitermarkus a=gdesmott

The PKG_CONFIG_ALLOW_CROSS env variable is required to cross compile
various crates such as openssl.

Fix #383

Co-authored-by: Guillaume Desmottes <[email protected]>
@bors bors bot closed this as completed in 07dba32 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
container-images feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docker: define PKG_CONFIG_ALLOW_CROSS gdesmott/cross
3 participants
@reitermarkus @gdesmott @Alexhuszagh