Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix *-solaris targets #1495

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

thirteenowls
Copy link
Contributor

Fixes #1424.

Adapted from rust-lang/rust#108951 and rust-lang/rust#81229 (with some minor changes to satisfy ShellCheck and account for broken symlinks).

This PR also renames x86_64-sun-solaris to x86_64-pc-solaris, as the former was deprecated in Rust 1.52.0 and removed in Rust 1.76.0, making this a breaking change.

The `x86_64-sun-solaris` target was deprecated in Rust 1.52.0[1]
and removed in Rust 1.76.0[2], in favour of  `x86_64-pc-solaris`.

[1]: rust-lang/rust#82216
[2]: rust-lang/rust#118091
@thirteenowls thirteenowls requested a review from a team as a code owner May 17, 2024 18:57
@Emilgardis
Copy link
Member

/ci try --target *solaris*

This comment has been minimized.

This comment has been minimized.

@Emilgardis
Copy link
Member

meh, I thought I fixed that...

/ci try --target *solaris

This comment has been minimized.

Copy link

Try run for comment

Successful Jobs

@Emilgardis Emilgardis added CI-sparcv9-sun-solaris Run CI for sparcv9-sun-solaris target CI-x86_64-pc-solaris Run CI for x86_64-pc-solaris target labels May 17, 2024
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Emilgardis Emilgardis added this pull request to the merge queue May 17, 2024
Merged via the queue into cross-rs:main with commit 19be834 May 17, 2024
23 checks passed
@thirteenowls thirteenowls deleted the fix-solaris-targets branch May 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-sparcv9-sun-solaris Run CI for sparcv9-sun-solaris target CI-x86_64-pc-solaris Run CI for x86_64-pc-solaris target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix *-solaris
2 participants