Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross when stdin is not a TTY #319

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Sep 10, 2019

When stdin is not a TTY, cross fails because it still passes -i to docker run, which makes Docker fail like so:

the input device is not a TTY

Apparently GitHub Actions doesn't have a TTY as stdin, so this is the fix to make cross work with GitHub Actions.

@rust-highfive
Copy link

r? @jamesmunns

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2019
src/docker.rs Outdated Show resolved Hide resolved
src/docker.rs Show resolved Hide resolved
src/docker.rs Outdated Show resolved Hide resolved
When stdin is not a TTY, cross fails because it still passes `-i` to
`docker run`, which makes Docker fail like so:
```
the input device is not a TTY
```
Apparently GitHub Actions doesn't have a TTY as stdin, so this is the
fix to make cross work with GitHub Actions.
@reitermarkus
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Sep 10, 2019
319: Fix cross when stdin is not a TTY r=reitermarkus a=CryZe

When stdin is not a TTY, cross fails because it still passes `-i` to `docker run`, which makes Docker fail like so:
```
the input device is not a TTY
```
Apparently GitHub Actions doesn't have a TTY as stdin, so this is the fix to make cross work with GitHub Actions.

Co-authored-by: Christopher Serr <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 10, 2019

Build succeeded

  • rust-embedded.cross

@bors bors bot merged commit d64cfb8 into cross-rs:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants