-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Dockerfiles. #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
requested review from
Dylan-DPC-zz,
jamesmunns and
a team
as code owners
September 24, 2019 13:25
burrbull
previously approved these changes
Sep 24, 2019
reitermarkus
force-pushed
the
refactoring
branch
3 times, most recently
from
September 25, 2019 00:25
39db7ec
to
4598c1e
Compare
reitermarkus
requested review from
a team and
burrbull
and removed request for
jamesmunns
September 25, 2019 02:13
therealprof
previously approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
326: Refactor Dockerfiles. r=therealprof a=reitermarkus Common packages are now installed with `common.sh`. Also fixes #330. Co-authored-by: Markus Reiter <[email protected]>
Build failed
|
reitermarkus
force-pushed
the
refactoring
branch
2 times, most recently
from
October 17, 2019 22:18
7b57d15
to
7e7bef3
Compare
reitermarkus
force-pushed
the
refactoring
branch
from
October 17, 2019 22:18
7e7bef3
to
3e11c60
Compare
bors try |
tryBuild succeeded
|
therealprof
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
bors bot
added a commit
that referenced
this pull request
Oct 18, 2019
326: Refactor Dockerfiles. r=therealprof a=reitermarkus Common packages are now installed with `common.sh`. Also fixes #330. Co-authored-by: Markus Reiter <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common packages are now installed with
common.sh
.Also fixes #330.