Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Dockerfiles. #326

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Refactor Dockerfiles. #326

merged 1 commit into from
Oct 18, 2019

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 24, 2019

Common packages are now installed with common.sh.

Also fixes #330.

burrbull
burrbull previously approved these changes Sep 24, 2019
therealprof
therealprof previously approved these changes Oct 17, 2019
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2019
326: Refactor Dockerfiles. r=therealprof a=reitermarkus

Common packages are now installed with `common.sh`.

Also fixes #330.

Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2019

Build failed

  • rust-embedded.cross

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Oct 18, 2019
@bors
Copy link
Contributor

bors bot commented Oct 18, 2019

try

Build succeeded

  • rust-embedded.cross

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 18, 2019
326: Refactor Dockerfiles. r=therealprof a=reitermarkus

Common packages are now installed with `common.sh`.

Also fixes #330.

Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 18, 2019

Build succeeded

  • rust-embedded.cross

@bors bors bot merged commit 3e11c60 into cross-rs:master Oct 18, 2019
@reitermarkus reitermarkus deleted the refactoring branch October 18, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build of armv7 image fails
3 participants