don't set RUSTFLAGS in aarch64-musl image #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the reported CI failures are unrelated to this PR. CI is broken on the main branch; PR #498 fixes that. |
reitermarkus
approved these changes
Dec 12, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 12, 2020
497: don't set RUSTFLAGS in aarch64-musl image r=reitermarkus a=japaric instead use a linker wrapper to work around issue rust-lang/rust#46651 not setting RUSTFLAGS inside the container lets end users pass rustc flags via `.cargo/config` this is an alternative to #464 that doesn't require bumping the MSRV of the `aarch64-unknown-linux-musl` target (that is the aarch64-musl image will continue to work with Rust 1.42 where bug rust-lang/rust#46651 is still presen ) 500: use runner setting specified in Cross.toml r=reitermarkus a=japaric fixes #499 Co-authored-by: Jorge Aparicio <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead use a linker wrapper to work around issue rust-lang/rust#46651
not setting RUSTFLAGS inside the container lets end users pass rustc flags via
.cargo/configthis is an alternative to #464 that doesn't require bumping the MSRV of the
aarch64-unknown-linux-musltarget (that is the aarch64-musl image will continue to work with Rust 1.42 where bug rust-lang/rust#46651 is still presen )