Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in dropbear.sh #687

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Fix broken link in dropbear.sh #687

merged 2 commits into from
Apr 10, 2022

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Apr 8, 2022

The broken link prevented Docker images from building.

@Jules-Bertholet Jules-Bertholet requested a review from a team as a code owner April 8, 2022 20:34
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Apr 8, 2022
Emilgardis
Emilgardis previously approved these changes Apr 8, 2022
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

thanks!

I assume this wasn't caught earlier because of cache. We should maybe build at least one image without cache to catch this.

bors bot added a commit that referenced this pull request Apr 8, 2022
687: Fix broken link in `dropbear.sh` r=Emilgardis a=Jules-Bertholet

The broken link prevented Docker images from building.

Co-authored-by: Jules Bertholet <[email protected]>
@Emilgardis
Copy link
Member

This also bumps the version, but I think that's fine

@bors
Copy link
Contributor

bors bot commented Apr 8, 2022

Build failed:

@Emilgardis
Copy link
Member

Emilgardis commented Apr 8, 2022

Interesting, I don't understand how these are failing (or rather, why the packages are gone)

@Emilgardis
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Apr 10, 2022
@bors
Copy link
Contributor

bors bot commented Apr 10, 2022

try

Build succeeded:

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

thanks!

@bors
Copy link
Contributor

bors bot commented Apr 10, 2022

Build succeeded:

@bors bors bot merged commit e7e7cfe into cross-rs:main Apr 10, 2022
@Jules-Bertholet Jules-Bertholet deleted the patch-1 branch April 10, 2022 14:46
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants