Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add soft-float ARMv7 targets. #741

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Add soft-float ARMv7 targets. #741

merged 1 commit into from
Jun 2, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Added armv7-unknown-linux-gnueabi and armv7-unknown-linux-musleabi targets, which target soft-float ARMv7-a processors.

Closes #354.

@Alexhuszagh
Add soft-float ARMv7 targets.
017678e 
Added `armv7-unknown-linux-gnueabi` and `armv7-unknown-linux-musleabi`
targets, which target soft-float ARMv7-a processors.

Closes cross-rs#354.
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 2, 2022 01:04
@Alexhuszagh
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jun 2, 2022
@bors
Try #741:
13adf63
@Alexhuszagh
Copy link
Contributor Author

@Emilgardis Is there any way in the future to only try 2 targets? It doesn't seem the CI accepts anything other than the first argument. Something like bors --target armv7-unknown-linux-gnueabi --target armv7-unknown-linux-musleabi, since a wildcard wouldn't exactly work here (due to the HF targets).

@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

try

Build succeeded:

@Emilgardis
Copy link
Member

Is there any way in the future to only try 2 targets?

we could probably implement that, makes sense.

Emilgardis
Emilgardis approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

Build succeeded:

@bors bors bot merged commit 1689de1 into cross-rs:main Jun 2, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
A-arm Area: ARM targets container-images enhancement
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.

Add support for armv7-unknown-linux-{gnu,musl}eabi
2 participants
@Alexhuszagh @Emilgardis