Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for target information. #768

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

Alexhuszagh
Copy link
Contributor

@Alexhuszagh Alexhuszagh commented Jun 8, 2022

Updated target information using the target-info command from cross-dev. Also added test detection for cross-dev, and fixed a bug with powerpc64le-unknown-linux-gnu using the wrong qemu architecture. I also removed targets for which we don't provide images, these are commented out below the table, so if we re-enable them they aren't gone entirely.

@Alexhuszagh Alexhuszagh added docs-problem no changelog A valid PR without changelog (no-changelog) labels Jun 8, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 8, 2022 22:37
@Alexhuszagh
Copy link
Contributor Author

Alexhuszagh commented Jun 8, 2022

UPDATE: I've made all the changes below.

We probably could remove some of these footnotes and remove some of the commented-out targets entirely.

This isn't due to cross, since we don't provide an image and is just handled by the host toolchain.

[1] iOS cross compilation is supported on macOS hosts.

This can just say no std component since I hope no one is using a compiler pre-2018 anymore, which will get duplicated if we ever add back x86_64-sun-solaris, which is also tier 3 now.

[3] No `std` component available as of 2017-01-10

We can comment this out currently as well until we restore the emscripten targets:

[6] libc = musl, gcc = emcc. The Docker images for these targets are currently not built automatically
due to a [compiler bug](https://github.com/rust-lang/rust/issues/85821), you will have to build them yourself for now.

So we should be able to remove [1], shift everything else down by 1, modify [3], and then comment out [6].

We'll also need to add the thumbv7* targets on #745 merges.

Updated target information using the `target-info` command from `cross-dev`. Also added test detection for `cross-dev`, and fixed a bug with `powerpc64le-unknown-linux-gnu` using the wrong qemu architecture.
@otavio otavio requested a review from Emilgardis June 9, 2022 20:10
@Emilgardis
Copy link
Member

missed the update! lgtm

bors r=otavio

@bors
Copy link
Contributor

bors bot commented Jun 9, 2022

Build succeeded:

@bors bors bot merged commit fdd7058 into cross-rs:main Jun 9, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-problem no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants