Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change target info to json and display them neatly #818

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Emilgardis
Copy link
Member

this is not a serious pr, just an attempt that maybe can become something

@Emilgardis Emilgardis added meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog) labels Jun 18, 2022
@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jun 18, 2022

I think this is a good idea, since we can always generate the table on the Rust side from the JSON output, which is what this already does, and we can plug it into CI or something if needed in the future (maybe a good idea if we're planning a release, to ensure the README is correct). Do we need rayon though? It's a very heavy dependency (a good one, but might increase compile times by a lot).

@Emilgardis
Copy link
Member Author

Do we need rayon though? It's a very heavy dependency (a good one, but might increase compile times by a lot).

Yeah, I placed it behind a feature to try mitigate that cost, but I thing it's impossible to not build it since we use --all-features

Used rayon because it took a long time to execute everything on my machine, I guess there is a way to do it without rayon but this was the simplest thing, can definitely remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants