enable coverage #829
enable coverage #829
Conversation
Emilgardis
force-pushed
the
feature/cov
branch
7 times, most recently
from
7e99832
to
502e1ac
Compare
|
bors try |
tryBuild succeeded: |
Emilgardis
force-pushed
the
feature/cov
branch
2 times, most recently
from
ae39f85
to
ed2c004
Compare
Emilgardis
force-pushed
the
feature/cov
branch
2 times, most recently
from
8974a42
to
b175434
Compare
| find ${artifacts} -name "lcov.*.info" -exec ./codecov -F $(echo {} | sed -n 's/lcov\.\(.*\)\.info/\1/p') \ | ||
| ${pr:+-P ${pr}} -f {} --sha ${sha_rev} -n $(echo {} | sed -n 's/lcov\.\(.*\)\.info/\1/p') \; |
There was a problem hiding this comment.
we may have to specify parent sha here, not sure if it really works when you have a staging/trying branch.
been trying to find prior art for codecov with bors integration but not able to find any good examples, only ones I find are my own previous tries :D
Emilgardis
force-pushed
the
feature/cov
branch
4 times, most recently
from
2f4d6ac
to
2a3fcc4
Compare
| find ${artifacts} -name "lcov.*.info" -exec ./codecov -F $(echo {} | sed -n 's/lcov\.\(.*\)\.info/\1/p') \ | ||
| ${pr:+-P ${pr}} -f {} --sha ${sha_rev} -n $(echo {} | sed -n 's/lcov\.\(.*\)\.info/\1/p') \; |
There was a problem hiding this comment.
I want this to never be able to fail, but on fail echo ::error title=Coverage upload failed::
There was a problem hiding this comment.
I don't know how to do that well though
|
Fix the changelog and r=me whenever. |
|
bors r+ |
829: enable coverage r=Alexhuszagh a=Emilgardis Implements coverage via lcov artifacts and uploads them to https://app.codecov.io/gh/cross-rs/cross Co-authored-by: Emil Gardström <[email protected]>
There was a problem hiding this comment.
Looking at the merge attempt, we'll likely need to export if the target supports LLVM code coverage. It may be worth just doing it on x86_64-unknown-linux-gnu.
| id: cov | ||
| uses: ./.github/actions/cargo-llvm-cov | ||
| if: steps.prepare-meta.outputs.has-image | ||
| with: |
There was a problem hiding this comment.
Probably change to:
if: steps.prepare-meta.outputs.has-image && matrix.target == 'x86_64-unknown-linux-gnu'There was a problem hiding this comment.
We don't need (or want) coverage on the test binaries, fixed this by clearing RUSTFLAGS, maybe it should be more specific though (i.e only remove instrument-coverage but not sure how to do that well)
|
Build failed: |
|
bors try --target mips64-unknown-linux-muslabi64 |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
Implements coverage via lcov artifacts and uploads them to https://app.codecov.io/gh/cross-rs/cross