Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cache dir tag when creating a target directory. #836

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Ensure cross is similar in functionality to cargo, and this minimizes network traffic by applications that may copy the project but do not wish to copy compiled code.

Closes #835.

Ensure `cross` is similar in functionality to `cargo`, and this
minimizes network traffic by applications that may copy the project but
do not wish to copy compiled code.

Closes cross-rs#835.
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 22, 2022 19:30
@Alexhuszagh
Copy link
Contributor Author

Alexhuszagh commented Jun 22, 2022

This also ensures creating the target directory doesn't fail, since we need to write the cache directory tag, which differs slightly but will produce effectively the same behavior as cargo (EDIT: just checked, the behavior is similar except the error codes are slightly different).

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 22, 2022

Build succeeded:

@bors bors bot merged commit cc61dc8 into cross-rs:main Jun 22, 2022
@Alexhuszagh Alexhuszagh deleted the cachedir_tag branch June 23, 2022 23:24
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross Doesn't Write a CACHEDIR.TAG
2 participants