Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of config build.env.passthrough values. #867

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Ensure build.env.passthrough values are correctly parsed, and do not return None, and ensure that they merge as expected with target.(...).env.passthrough values.

Ensure `build.env.passthrough` values are correctly parsed, and do not
return `None`, and ensure that they merge as expected with
`target.(...).env.passthrough` values.
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 26, 2022 15:28
@Alexhuszagh Alexhuszagh linked an issue Jun 26, 2022 that may be closed by this pull request
11 tasks
@Alexhuszagh Alexhuszagh added this to the v0.2.3 milestone Jun 26, 2022
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 26, 2022

Build succeeded:

@bors bors bot merged commit 037070d into cross-rs:main Jun 26, 2022
@Alexhuszagh Alexhuszagh deleted the array_merging branch June 26, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Parsing of Arrays in Config Files
2 participants