-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wamp_session: set_exception on the correct future #229
Conversation
ah, right! thanks for contributing, I've enabled CI to run (only required on your 1st contribution) .. it runs into CI unfort. (not related to this PR):
|
so essentially, we need to change
according to
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ |
Hi @oberstet I've pushed an attempted fix for the CI, I will iterate should it prove insufficient, thanks. |
953763b
to
93e7383
Compare
well, the environment vars are indeed needed;) so the syntax in the github job control needs a change:
also, in doing so, we need to ensure that the job meta variable |
The env vars have been set correctly via the |
7b228ce
to
95529ad
Compare
95529ad
to
a9bc73a
Compare
OK, the non-conan builds are passing. conan seems to be broken by conan-io/conan#8788 I'm out of time for fixing the other CI issues as I'm not familiar with conan and don't use windows. |
alright, I have found this https://blog.conan.io/2021/09/03/conancenter-declare-bintray-obsolete.html let me see if I can add that to your PR and try using https://conan.bintray.com [OLD] => https://center.conan.io [NEW] |
that has worked #230 thanks for contributing! |
Thanks! |
Currently the start future is incorrectly signaled, probably cut'n'paste from the start method above.