Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST bridge: remove WAMP ticket auth forwarding #1500

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Feb 13, 2019

No description provided.

@markope
Copy link
Contributor

markope commented Feb 14, 2019

That's a scary pull request. Is this really removing ticket authentication from crossbar?
We are using this feature.

@oberstet
Copy link
Contributor

Ah, no;) What's removed is only code that forwarded HTTP to WAMP-Ticket Auth - that code is a security problem (and the design approach unfortunately "broken by design"). we are working on a replacement for the ability to authenticate the incoming HTTP to Web services defined in crossbar ..

@oberstet oberstet changed the title Remove ticket auth REST bridge: remove WAMP ticket auth forwarding Feb 14, 2019
@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #1500 into master will decrease coverage by 0.41%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1500      +/-   ##
=========================================
- Coverage   37.42%     37%   -0.42%     
=========================================
  Files          76      77       +1     
  Lines       11602   11711     +109     
  Branches     2120    2130      +10     
=========================================
- Hits         4342    4334       -8     
- Misses       6839    6947     +108     
- Partials      421     430       +9
Impacted Files Coverage Δ
crossbar/_log_categories.py 100% <ø> (ø) ⬆️
crossbar/common/checkconfig.py 17.86% <ø> (+0.07%) ⬆️
crossbar/bridge/rest/common.py 93.17% <90%> (+11.08%) ⬆️
crossbar/router/service.py 26.33% <0%> (-5.02%) ⬇️
crossbar/router/session.py 57.74% <0%> (-2.63%) ⬇️
crossbar/router/broker.py 38.64% <0%> (-2.41%) ⬇️
crossbar/router/realmstore.py 33.01% <0%> (-1.89%) ⬇️
crossbar/router/router.py 57.75% <0%> (-1.8%) ⬇️
crossbar/router/dealer.py 40.6% <0%> (-0.38%) ⬇️
crossbar/node/main.py 9.2% <0%> (-0.02%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc7155...e3dfb07. Read the comment docs.

@oberstet oberstet merged commit 8f427aa into crossbario:master Feb 22, 2019
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Nov 25, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Nov 25, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Nov 26, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Nov 27, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
halstead pushed a commit to openembedded/meta-openembedded that referenced this pull request Nov 29, 2021
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Trevor Gamblin <[email protected]>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Trevor Gamblin <[email protected]>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
Changelog:
fix: autobahn installation in docker
     (crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
     (crossbario/crossbar#1500,
     crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
     (crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
     (crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
     (crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
     (crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Trevor Gamblin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants