Run sanitizers on CI #591
Merged
Run sanitizers on CI #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
san
branch
2 times, most recently
from
33f39c7
to
dbdd891
Compare
taiki-e
force-pushed
the
san
branch
2 times, most recently
from
04621b1
to
74e3e01
Compare
taiki-e
force-pushed
the
san
branch
6 times, most recently
from
6e9753d
to
c6957f3
Compare
taiki-e
force-pushed
the
san
branch
2 times, most recently
from
0bee96d
to
f1b6d98
Compare
taiki-e
added
the
S-waiting-on-author
taiki-e
force-pushed
the
san
branch
5 times, most recently
from
fdf1af2
to
784d002
Compare
taiki-e
removed
the
S-waiting-on-author
taiki-e
force-pushed
the
san
branch
4 times, most recently
from
f30f693
to
523d7df
Compare
taiki-e
commented
Jan 5, 2021
Comment on lines
+202
to
204
| #[cfg(not(crossbeam_sanitize))] // TODO: assertions failed due to `cfg(crossbeam_sanitize)` reduce `internal::MAX_OBJECTS` | ||
| #[test] | ||
| fn incremental() { |
There was a problem hiding this comment.
I don't know why this test fails when we reduce internal::MAX_OBJECTS, but it also fails when I run a normal test with --cfg crossbeam_sanitize. (And, except for cfg(test) code, cfg(crossbeam_sanitize) only changes internal::MAX_OBJECTS.)
$ RUSTFLAGS='--cfg crossbeam_sanitize' cargo test --lib
...
---- collector::tests::incremental stdout ----
thread 'collector::tests::incremental' panicked at 'assertion failed: curr - last <= 1024', crossbeam-epoch/src/collector.rs:227:13
stack backtrace:
0: rust_begin_unwind
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/std/src/panicking.rs:493:5
1: core::panicking::panic_fmt
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/core/src/panicking.rs:92:14
2: core::panicking::panic
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/core/src/panicking.rs:50:5
3: crossbeam_epoch::collector::tests::incremental
at ./src/collector.rs:227:13
4: crossbeam_epoch::collector::tests::incremental::{{closure}}
at ./src/collector.rs:204:5
5: core::ops::function::FnOnce::call_once
at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
6: core::ops::function::FnOnce::call_once
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failures:
collector::tests::incremental
test result: FAILED. 35 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.01s
error: test failed, to rerun pass '--lib'
There was a problem hiding this comment.
I think it's worth reporting in a separate issue. @taiki-e would you please?
There was a problem hiding this comment.
That makes sense. I've filed #662.
|
@jeehoonkang Are there any changes that you'd like me to make? |
jeehoonkang
approved these changes
Feb 15, 2021
Comment on lines
+202
to
204
| #[cfg(not(crossbeam_sanitize))] // TODO: assertions failed due to `cfg(crossbeam_sanitize)` reduce `internal::MAX_OBJECTS` | ||
| #[test] | ||
| fn incremental() { |
There was a problem hiding this comment.
I think it's worth reporting in a separate issue. @taiki-e would you please?
|
bors r=jeehoonkang |
|
Build succeeded: |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds AddressSanitizer/MemorySanitizer/ThreadSanitizer tests to CI.
See #589 (tsan: data race in deque), #644 (tsan: data race in atomic), and #614 (asan: memory leak in skiplist) for issues reported by sanitizers.
Closes #154
Closes #589
Closes #644
Refs: