Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AtomicCell lockfree for u8, u16, u32, u64 sized values. #454

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Make AtomicCell lockfree for u8, u16, u32, u64 sized values. #454

merged 1 commit into from
Dec 19, 2019

Conversation

manuthambi
Copy link
Contributor

Fixes #423

@manuthambi manuthambi changed the title Make AtomicCell lockfree for i8, i16, i32, u8, u16, u32 Make AtomicCell lockfree for u8, u16, u32 sized values. Dec 18, 2019
@manuthambi manuthambi mentioned this pull request Dec 18, 2019
Closed
@manuthambi manuthambi changed the title Make AtomicCell lockfree for u8, u16, u32 sized values. Make AtomicCell lockfree for u8, u16, u32, u64 sized values. Dec 19, 2019
@jeehoonkang
Copy link
Contributor

I think we need to discuss the minimum supported Rust version (MSRV). This PR is bumping it from 1.28 to 1.34, which is quite okay IMO. Any thoughts?

(Actually, I'd like to bump it to 1.36, which is required for #452.)

@manuthambi
Use integer atomics for for u8, u16, u32, u64 to implement lockfree A…
11fbf05 
…tomicCell

for types with those widths.

Integer atomics are stable starting rust 1.34. Use autocfg to cleanup
the detection of availability of atomics for both stable and nightly.

Issue crossbeam-rs#454
@manuthambi
Copy link
Contributor Author

I reworked the patch to use autocfg crate. The code is cleaner and we don't need the MSRV bump anymore.

But bumping MSRV is a great idea regardless.

@jeehoonkang
Copy link
Contributor

I think it's great! Thank you.

bors r+

bors bot added a commit that referenced this pull request Dec 19, 2019
@bors @manuthambi
Merge #454
355d65f 
454: Make AtomicCell lockfree for u8, u16, u32, u64 sized values. r=jeehoonkang a=manuthambi

Fixes #423

Co-authored-by: Manu Thambi <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 19, 2019

Build succeeded

@bors bors bot merged commit 11fbf05 into crossbeam-rs:master Dec 19, 2019
@jonhoo jonhoo mentioned this pull request Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AtomicCell without lock for non-usize values in stable.
2 participants
@manuthambi @jeehoonkang