Simplify tick channel #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 25, 2019
456: Simplify tick channel r=stjepang a=stjepang Due to the way `recv()` was implemented for the tick flavor, there was always some unintended drift because we had a loop that sleeps until the next tick and then checks if the tick happened. This PR simplifies the `recv()` method and fixes the drift. Now we try to receive the message first and *then* sleep until the next tick. Fixes #406 Co-authored-by: Stjepan Glavina <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way
recv()was implemented for the tick flavor, there was always some unintended drift because we had a loop that sleeps until the next tick and then checks if the tick happened.This PR simplifies the
recv()method and fixes the drift. Now we try to receive the message first and then sleep until the next tick.Fixes #406