Enable tests on Windows on CI #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
changed the title
taiki-e
commented
May 25, 2020
| # These jobs don't actually test anything, but they're used to tell bors the | ||
| # build completed, as there is no practical way to detect when a workflow is | ||
| # successful listening to webhooks only. | ||
| # | ||
| # ALL THE PREVIOUS JOBS NEEDS TO BE ADDED TO THE `needs` SECTION OF THIS JOB! |
There was a problem hiding this comment.
This is a realistic way for bors to receive build status from Github Actions, which do a lot of jobs (It's used in rust-lang/rust, rust-lang/clippy, etc. Previously we had to manually manage all job names.)
taiki-e
force-pushed
the
windows
branch
2 times, most recently
from
073a81a
to
e9a5cbb
Compare
|
(I originally tried to add both macOS and Windows to the CI, but I had a lot of locally non-reproducible errors with macOS, so I opened a windows-only PR for now.) |
|
Now, this should be ready for review. |
jeehoonkang
reviewed
May 25, 2020
ghost
approved these changes
May 25, 2020
|
bors r+ |
|
Hm, bors-ng doesn't seem to handle the change from fork to bors.toml correctly? Related: bors-ng/bors-ng#806 bors r- |
|
So, I'll open the PR from this repo's branch with the same commit. |
|
Closing in favor of #519 |
bors bot
added a commit
that referenced
this pull request
May 25, 2020
519: Enable tests on Windows on CI r=taiki-e a=taiki-e Replaces #518 (changing bors-ng configuration from a forked branch doesn't seem to work well...) Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossbeam has some
cfg(windows)code, but we don't test on CI. It would be nice to be able to test these with CI.crossbeam/crossbeam-utils/src/thread.rs
Line 537 in 4879038
crossbeam/crossbeam-utils/tests/thread.rs
Line 196 in 4879038
Travis's Windows support was experimental and very slow, but GitHub Actions' Windows support relatively fast. Hopefully we can add this to our CI.