Do not provide AtomicCell when cfg(crossbeam_loom) is enabled #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
loom-atomic-cell
branch
from
616d382
to
85eac6a
Compare
taiki-e
commented
Feb 9, 2022
Comment on lines
+27
to
+30
| // We cannot provide AtomicCell under cfg(crossbeam_loom) because loom's atomic | ||
| // types have a different in-memory representation than the underlying type. | ||
| // TODO: The latest loom supports fences, so fallback using seqlock may be available. | ||
| #[cfg(not(crossbeam_loom))] |
There was a problem hiding this comment.
(Well, this todo may be difficult because seqlock has another issue.)
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Mar 15, 2022
800: Prepare for the next release r=taiki-e a=taiki-e - crossbeam-channel 0.5.2 -> 0.5.3 - Fix panic on very large timeout. (#798) - crossbeam-epoch 0.9.7 -> 0.9.8 - Make `Atomic::null()` const function at 1.61+. (#797) - crossbeam-queue 0.3.4 -> 0.3.5 - Add `ArrayQueue::force_push`. (#789) - crossbeam-utils 0.8.7 -> 0.8.8 - Fix a bug when unstable `loom` support is enabled. (#787) Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot provide AtomicCell under
cfg(crossbeam_loom)because loom's atomic types have a different in-memory representation than the underlying type. (tokio-rs/loom#253)crossbeam/crossbeam-utils/src/atomic/atomic_cell.rs
Lines 35 to 42 in bd83e1f
fyi @jonhoo