Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS SDK v2 version #383

Closed
muvaf opened this issue Oct 14, 2020 · 8 comments
Closed

Update AWS SDK v2 version #383

muvaf opened this issue Oct 14, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@muvaf
Copy link
Member

muvaf commented Oct 14, 2020

What problem are you facing?

I've been getting The XML you provided was not well-formed or did not validate against our published schema in some S3 calls and I suspect it might be related to the AWS SDK version (github.com/aws/aws-sdk-go-v2 v0.23.0) we are using.

How could Crossplane help solve your problem?

Update to v0.26.0 which has some significant changes from what I can tell.

@muvaf muvaf added the enhancement New feature or request label Oct 14, 2020
@enderv
Copy link
Contributor

enderv commented Jan 5, 2021

Started working on bumping to their rc .0.31.0 as I have time. It is indeed a major change.

@muvaf
Copy link
Member Author

muvaf commented Jan 6, 2021

@enderv FWIW, we use AWS SDK v1 as well, which is GA as opposed to v2. So, if you don't want to deal with updating SDK, you can opt for using v1 in the controller you want to make a change.

@negz
Copy link
Member

negz commented Jan 11, 2021

We're continuing to use SDK v1 because ACK uses SDK v1 - we will revisit this later once there's ACK support for v2.

@negz negz closed this as completed Jan 11, 2021
@enderv
Copy link
Contributor

enderv commented Jan 12, 2021

Question on this: all of the current non ack resources use v2 already. Just gonna stick on the old v2 version until they go to ack generated resources?

@muvaf
Copy link
Member Author

muvaf commented Jan 12, 2021

@enderv I think we're indifferent about what SDK they use but unless necessary, I wouldn't spend much effort updating them to newer v2 versions. In fact, we can think about downgrading them to v1 if the feature that's available in newer v2 versions is available there.

@muvaf muvaf reopened this Feb 15, 2021
@muvaf muvaf changed the title Update to new AWS SDK version Update AWS SDK v2 version Feb 24, 2021
@muvaf
Copy link
Member Author

muvaf commented Mar 19, 2021

v2 SDK has gone GA and the current released version is v1.3.0 which I think we should upgrade to as soon as we can.

@enderv
Copy link
Contributor

enderv commented Mar 19, 2021

Have done a lot of work on this in my aws-update branch to get to 1.1. Just keep getting distracted with other things and new resources keep coming in. Did another rebase this morning and a few tests are failing but just wanted to call it out here in case someone else had more time and didn't want to start from scratch.

@muvaf
Copy link
Member Author

muvaf commented Oct 4, 2021

Fixed with #602 and #855

@muvaf muvaf closed this as completed Oct 4, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
…to-date-test

Update "Ready" test condition to "UpToDate"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants