-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AWS SDK v2 version #383
Comments
Started working on bumping to their rc .0.31.0 as I have time. It is indeed a major change. |
@enderv FWIW, we use AWS SDK v1 as well, which is GA as opposed to v2. So, if you don't want to deal with updating SDK, you can opt for using v1 in the controller you want to make a change. |
We're continuing to use SDK v1 because ACK uses SDK v1 - we will revisit this later once there's ACK support for v2. |
Question on this: all of the current non ack resources use v2 already. Just gonna stick on the old v2 version until they go to ack generated resources? |
@enderv I think we're indifferent about what SDK they use but unless necessary, I wouldn't spend much effort updating them to newer v2 versions. In fact, we can think about downgrading them to v1 if the feature that's available in newer v2 versions is available there. |
v2 SDK has gone GA and the current released version is v1.3.0 which I think we should upgrade to as soon as we can. |
Have done a lot of work on this in my aws-update branch to get to 1.1. Just keep getting distracted with other things and new resources keep coming in. Did another rebase this morning and a few tests are failing but just wanted to call it out here in case someone else had more time and didn't want to start from scratch. |
…to-date-test Update "Ready" test condition to "UpToDate"
What problem are you facing?
I've been getting
The XML you provided was not well-formed or did not validate against our published schema
in some S3 calls and I suspect it might be related to the AWS SDK version (github.com/aws/aws-sdk-go-v2 v0.23.0
) we are using.How could Crossplane help solve your problem?
Update to v0.26.0 which has some significant changes from what I can tell.
The text was updated successfully, but these errors were encountered: