Upgrade to terraform provider v5.46.0 #1271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbush
force-pushed
the
terraform-upgrade/v5.46.0
branch
from
588a1d8
to
ccb0fe8
Compare
3 tasks
mbbush
force-pushed
the
terraform-upgrade/v5.46.0
branch
5 times, most recently
from
7ca93f7
to
724c288
Compare
Signed-off-by: Christopher Haar <[email protected]>
Signed-off-by: Christopher Haar <[email protected]> Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
mbbush
force-pushed
the
terraform-upgrade/v5.46.0
branch
from
724c288
to
b296213
Compare
|
/test-examples="examples/eks/v1beta1/clusterauth.yaml" |
|
/test-examples="examples/fsx/v1beta1/ontapfilesystem.yaml" |
|
/test-examples="examples/emrserverless/v1beta1/application.yaml" |
Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
|
/test-examples="examples/secretsmanager/v1beta1/secretrotation.yaml" |
|
/test-examples="examples/cloud9/v1beta1/environmentec2.yaml" |
|
/test-examples="examples/ecs/v1beta1/cluster.yaml" |
|
/test-examples="examples/appautoscaling/v1beta1/scheduledaction.yaml" |
This was referenced May 9, 2024
|
Any updates on this PR? Happy to help out where I can. |
|
@johnathan-sq we will be focusing on finalizing the TF provider upgrade next week. |
4 tasks
|
Superseded by #1315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Upgrade to the latest terraform provider version. There have been several complications, discussed below.
I have:
make reviewableto ensure this PR is ready for review.Complications
This is integrating several separate pieces, which conflict with each other.
.Sessionproperty onconns.AWSClient.Sessionproperty private (which isn't a breaking change to their public API since it's ininternal, but we use a forked version of the TF provider that exposes some internal objects to make our no-fork architecture possible).eksctlresolved it by removing theRetryMetricsHeaderfrom the middleware, but then later reverted that change after upgrading to aws go sdk v2 version 1.25.0.ClusterAuthuptest passes on this branch, but I'd still appreciatePotentially incompatible schema changes:
From https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8792472872/job/24128687844
Report breaking CRD OpenAPI v3 schema changes:
Report native schema version changes
Uptest runs
✔️ EKS ClusterAuth: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8794111828
✔️ FSX OnTapFileSystem: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8794383020
✔️ EMR Serverless Application: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8794565770
✔️ Cloud9 EnvironmentEc2: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8795118229
✔️ Secretsmanager SecretRotation: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8795106214
Terraform provider changelog lines to look into:
This is a very light filter through the tf provider changelog, with things I though might be slightly notable or worth checking. I'm sure there are a bunch of things on here that just won't matter at all.
scalable_dimensionas an additional filterderegister_on_new_revisionto allow keeping prior versions ACTIVE when a new revision is published.monitor_dimensionto [ForceNew]image_idis Requiredoutput_formatkms_key_idargumenttrigger.destination_arnandtrigger.eventsaws_config_organization_custom_rule.lambda_function_arns3_bucket_arnattribute value from state read/refreshperformance_insights_retention_periodparameter_group_namewhenreplicate_source_dbis in different region.character_set_namewhenreplicate_source_db,restore_to_point_in_time, orsnapshot_identifieris setauthfromTypeListtoTypeSetas order is not significantsource_idsas Optional. This fixes a regression introduced in [v5.31.0]replication_task_settingsunset to use default settings.DEFAULT) forconfiguration.execute_command_configuration.loggingpanic: interface conversion: interface {} is nil, not map[string]interface {}whenconfiguration,configuration.execute_command_configuration, orconfiguration.execute_command_configuration.log_configurationare emptyservice_connect_configuration.service.tls.issuer_cert_authority.aws_pca_authority_arnis Requiredlifecycle_policymaximum item limit to 3throughput_capacityis Optionalnumber_of_workersandworker_typeas optional/computed, preventing persistent differences whenmax_capacityis set.aws_instance, addebs_block_device.*.tags_allandroot_block_device.*.tags_allattributes which include default tagsextended_s3_configuration.processing_configuration.processors.parametersfromTypeListtoTypeSetas order is not significantsource_code_hashdoes not change.load_balancer_arnsattributeInvalidNetworkAclID.NotFounderrors on resource Deleteloggingargument is now deprecated. Use theaws_redshift_loggingresource instead.snapshot_copyargument is now deprecated. Use theaws_redshift_snapshot_copyresource instead.namecasing changes./fromkeyto maintain AWS SDK for Go v1 (pre-v5.17.0) compatibility./fromkeyto maintain AWS SDK for Go v1 (pre-v5.17.0) compatibility./fromkeyto maintain AWS SDK for Go v1 (pre-v5.17.0) compatibilityInvalidParameterException: The parameter RemoveFromVersionId can't be empty. Staging label AWSCURRENT is currently attached to version ..., so you must explicitly reference that version in RemoveFromVersionIderrors when a secret is updated outside TerraformInvalidRequestExceptiondata_typeis updated.