Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removing RetryMetricsHeader in presigned requests #7563

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

yuxiang-zhang
Copy link
Member

Description

With the update to [email protected], API server requests containing URLs presigned by sts.PresignClient fail with error generating token: failed to presign caller identity: not found, RetryMetricsHeader.

Previous issue #7486 has this RetryMetricsHeader header removed. This PR reverts that change.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuxiang-zhang yuxiang-zhang merged commit d05aee2 into main Feb 16, 2024
9 of 10 checks passed
@yuxiang-zhang yuxiang-zhang deleted the revert-fix-presigned branch February 16, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants