-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aws batch compute and job queue #1489
base: main
Are you sure you want to change the base?
feat: add aws batch compute and job queue #1489
Conversation
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
1 similar comment
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
3b97ca6
to
45964a5
Compare
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
1 similar comment
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
1 similar comment
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
1 similar comment
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
f71b8b4
to
4a45ef6
Compare
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
The test fails because of hardcoding securityGroupIds: and subnets: values. Can I know how to fix this? The computeenvironment crd does not allow subnet and securitygroupid reference. |
@sachinmalanki, here's an example configuration: https://github.com/crossplane-contrib/provider-upjet-aws/blob/v1.14.0/config/apprunner/config.go#L14-L23 |
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Thanks for the help @mergenci, I have updated the MR with reference and selector. |
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
Signed-off-by: sachinmalanki <[email protected]>
/test-examples="examples/batch/v1beta1/jobqueue.yaml,examples/batch/v1beta1/computeenvironment.yaml" |
Looks like computeEnvironment resource fails to delete because of |
Description of your changes
Adding AWS Batch Compute Environment(aws_batch_compute_environment) and Job Queue(aws_batch_job_queue)
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Manually tested as per the guide
Batch compute environment
Job Queue