feat: add aws batch compute and job queue #1489
Conversation
sachinmalanki
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
|
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
1 similar comment
|
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
sachinmalanki
force-pushed
the
aws-batch-resources
branch
from
3b97ca6
to
45964a5
Compare
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
1 similar comment
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
|
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
1 similar comment
|
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
|
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
1 similar comment
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
|
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
sachinmalanki
force-pushed
the
aws-batch-resources
branch
from
f71b8b4
to
4a45ef6
Compare
|
/test-examples="examples/batch/v1beta1/computeenvironment.yaml" |
|
/test-examples="examples/batch/v1beta1/jobqueue.yaml" |
|
The test fails because of hardcoding securityGroupIds: and subnets: values. Can I know how to fix this? The computeenvironment crd does not allow subnet and securitygroupid reference. |
|
@sachinmalanki, here's an example configuration: https://github.com/crossplane-contrib/provider-upjet-aws/blob/v1.14.0/config/apprunner/config.go#L14-L23 |
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: Blake R <[email protected]>
Signed-off-by: Blake R <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
…al defaulting Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
Signed-off-by: sachinmalanki <[email protected]>
|
Hi @turkenf. Thanks for the suggestions, I have rebased and made the changes. Could you please review ? |
@sachinmalanki, we have hooks for this kind of cases. We can use pre-delete-hook. Here is an example: yaml and sh files. I noticed that there are currently 47 commits in the PR’s commit history. When you have a chance, could you please fork your PR from the latest main branch and squash your commits? It would help keep the history clean. Thanks so much! |
config/batch/config.go
Outdated
| r.References = config.References{ | ||
| "compute_resources.subnets": config.Reference{ | ||
| TerraformName: "aws_subnet", | ||
| RefFieldName: "SubnetRefs", | ||
| SelectorFieldName: "SubnetSelector", | ||
| }, | ||
| "compute_resources.security_group_ids": config.Reference{ | ||
| TerraformName: "aws_security_group", | ||
| RefFieldName: "SecurityGroupRefs", | ||
| SelectorFieldName: "SecurityGroupSelector", | ||
| }, | ||
| } |
There was a problem hiding this comment.
| r.References = config.References{ | |
| "compute_resources.subnets": config.Reference{ | |
| TerraformName: "aws_subnet", | |
| RefFieldName: "SubnetRefs", | |
| SelectorFieldName: "SubnetSelector", | |
| }, | |
| "compute_resources.security_group_ids": config.Reference{ | |
| TerraformName: "aws_security_group", | |
| RefFieldName: "SecurityGroupRefs", | |
| SelectorFieldName: "SecurityGroupSelector", | |
| }, | |
| } | |
| r.References["compute_resources.subnets"] = config.Reference{ | |
| TerraformName: "aws_subnet", | |
| RefFieldName: "SubnetRefs", | |
| SelectorFieldName: "SubnetSelector", | |
| } | |
| r.References["compute_resources.security_group_ids"] = config.Reference{ | |
| TerraformName: "aws_security_group", | |
| RefFieldName: "SecurityGroupRefs", | |
| SelectorFieldName: "SecurityGroupSelector", | |
| } |
|
I have raised another PR - #1542 with all the changes suggested. |
Signed-off-by: sachinmalanki <[email protected]>
|
Hi @sachinmalanki, which PR will we continue with? |
|
Lets continue with #1542. let me close this PR |
Description of your changes
Adding AWS Batch Compute Environment(aws_batch_compute_environment) and Job Queue(aws_batch_job_queue)
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually tested as per the guide
Batch compute environment
Job Queue
