Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving ec2 (17) resources to v1beta1 version #65 #130

Merged
merged 7 commits into from
Nov 11, 2022
Merged

Moving ec2 (17) resources to v1beta1 version #65 #130

merged 7 commits into from
Nov 11, 2022

Conversation

dverveiko
Copy link
Contributor

@Upbound-CLA
Copy link

Upbound-CLA commented Nov 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

turkenh
turkenh reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rebase your change on top of latest main.

@turkenh
Copy link
Contributor

turkenh commented Nov 9, 2022

Can you add test-examples comment to see if it works for you?

@ulucinar
Copy link
Collaborator

ulucinar commented Nov 9, 2022

Hi @dverveiko, could you please add a comment like the following:

/test-examples="examples/ec2/availabilityzonegroup.yaml,examples/ec2/capacityreservation.yaml,examples/ec2/carriergateway.yaml,examples/ec2/defaultsubnet.yaml,examples/ec2/defaultvpc.yaml,examples/ec2/defaultvpcdhcpoptions.yaml,examples/ec2/ebsdefaultkmskey.yaml,examples/ec2/ebsencryptionbydefault.yaml,examples/ec2/ebssnapshotcopy.yaml,examples/ec2/ebssnapshotimport.yaml,examples/ec2/host.yaml,examples/ec2/networkinsightspath.yaml,examples/ec2/serialconsoleaccess.yaml,examples/ec2/subnetcidrreservation.yaml,examples/ec2/trafficmirrorfilter.yaml,examples/ec2/trafficmirrorfilterrule.yaml,examples/ec2/transitgatewayconnect.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/availabilityzonegroup.yaml,examples/ec2/capacityreservation.yaml,examples/ec2/carriergateway.yaml,examples/ec2/defaultsubnet.yaml,examples/ec2/defaultvpc.yaml,examples/ec2/defaultvpcdhcpoptions.yaml,examples/ec2/ebsdefaultkmskey.yaml,examples/ec2/ebsencryptionbydefault.yaml,examples/ec2/ebssnapshotcopy.yaml,examples/ec2/ebssnapshotimport.yaml,examples/ec2/host.yaml,examples/ec2/networkinsightspath.yaml,examples/ec2/serialconsoleaccess.yaml,examples/ec2/subnetcidrreservation.yaml,examples/ec2/trafficmirrorfilter.yaml,examples/ec2/trafficmirrorfilterrule.yaml,examples/ec2/transitgatewayconnect.yaml"

2 similar comments
@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/availabilityzonegroup.yaml,examples/ec2/capacityreservation.yaml,examples/ec2/carriergateway.yaml,examples/ec2/defaultsubnet.yaml,examples/ec2/defaultvpc.yaml,examples/ec2/defaultvpcdhcpoptions.yaml,examples/ec2/ebsdefaultkmskey.yaml,examples/ec2/ebsencryptionbydefault.yaml,examples/ec2/ebssnapshotcopy.yaml,examples/ec2/ebssnapshotimport.yaml,examples/ec2/host.yaml,examples/ec2/networkinsightspath.yaml,examples/ec2/serialconsoleaccess.yaml,examples/ec2/subnetcidrreservation.yaml,examples/ec2/trafficmirrorfilter.yaml,examples/ec2/trafficmirrorfilterrule.yaml,examples/ec2/transitgatewayconnect.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/availabilityzonegroup.yaml,examples/ec2/capacityreservation.yaml,examples/ec2/carriergateway.yaml,examples/ec2/defaultsubnet.yaml,examples/ec2/defaultvpc.yaml,examples/ec2/defaultvpcdhcpoptions.yaml,examples/ec2/ebsdefaultkmskey.yaml,examples/ec2/ebsencryptionbydefault.yaml,examples/ec2/ebssnapshotcopy.yaml,examples/ec2/ebssnapshotimport.yaml,examples/ec2/host.yaml,examples/ec2/networkinsightspath.yaml,examples/ec2/serialconsoleaccess.yaml,examples/ec2/subnetcidrreservation.yaml,examples/ec2/trafficmirrorfilter.yaml,examples/ec2/trafficmirrorfilterrule.yaml,examples/ec2/transitgatewayconnect.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/availabilityzonegroup.yaml,examples/ec2/capacityreservation.yaml,examples/ec2/carriergateway.yaml,examples/ec2/defaultsubnet.yaml,examples/ec2/defaultvpc.yaml,examples/ec2/defaultvpcdhcpoptions.yaml,examples/ec2/ebsdefaultkmskey.yaml,examples/ec2/ebsencryptionbydefault.yaml,examples/ec2/ebssnapshotcopy.yaml,examples/ec2/ebssnapshotimport.yaml,examples/ec2/host.yaml,examples/ec2/networkinsightspath.yaml,examples/ec2/serialconsoleaccess.yaml,examples/ec2/subnetcidrreservation.yaml,examples/ec2/trafficmirrorfilter.yaml,examples/ec2/trafficmirrorfilterrule.yaml,examples/ec2/transitgatewayconnect.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/availabilityzonegroup.yaml,examples/ec2/capacityreservation.yaml,examples/ec2/carriergateway.yaml,examples/ec2/defaultsubnet.yaml,examples/ec2/defaultvpc.yaml,examples/ec2/defaultvpcdhcpoptions.yaml,examples/ec2/ebsdefaultkmskey.yaml,examples/ec2/ebsencryptionbydefault.yaml,examples/ec2/ebssnapshotcopy.yaml,examples/ec2/ebssnapshotimport.yaml,examples/ec2/host.yaml,examples/ec2/networkinsightspath.yaml,examples/ec2/serialconsoleaccess.yaml,examples/ec2/subnetcidrreservation.yaml,examples/ec2/trafficmirrorfilter.yaml,examples/ec2/trafficmirrorfilterrule.yaml,examples/ec2/transitgatewayconnect.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/ebssnapshotimport.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/ebssnapshotimport.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/transitgatewayconnect.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/defaultsubnet.yaml"

@dverveiko
Copy link
Contributor Author

/test-examples="examples/ec2/networkinsightspath.yaml"

@dverveiko dverveiko assigned ulucinar and dverveiko and unassigned ulucinar Nov 11, 2022
ezgidemirel
ezgidemirel approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dverveiko!!

@dverveiko dverveiko merged commit a897ccc into crossplane-contrib:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenh turkenh turkenh left review comments

@ezgidemirel ezgidemirel ezgidemirel approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

Assignees

@dverveiko dverveiko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving ec2 (17) resources to v1beta1 version
5 participants
@dverveiko @Upbound-CLA @turkenh @ulucinar @ezgidemirel