Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): set correct description for field #1386

Merged
merged 1 commit into from
Jul 1, 2024
Merged

feat(eks): set correct description for field #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/eks/v1beta2/zz_nodegroup_types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion config/eks/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func Configure(p *config.Provider) {
},
}
r.UseAsync = true
r.MetaResource.ArgumentDocs["launch_template.version"] = `- (Required) EC2 Launch Template version number. While the API accepts values like $Default and $Latest, the API will convert the value to the associated version number (e.g., 1). Using the default_version or latest_version attribute of the aws_launch_template resource or data source is recommended for this argument.`
r.MetaResource.ArgumentDocs["launch_template.version"] = `- (Required) EC2 Launch Template version number.`
r.MetaResource.ArgumentDocs["subnet_ids"] = `- Identifiers of EC2 Subnets to associate with the EKS Node Group. Amazon EKS managed node groups can be launched in both public and private subnets. If you plan to deploy load balancers to a subnet, the private subnet must have tag kubernetes.io/role/internal-elb, the public subnet must have tag kubernetes.io/role/elb.`
})
p.AddResourceConfigurator("aws_eks_identity_provider_config", func(r *config.Resource) {
Expand Down
21 changes: 3 additions & 18 deletions package/crds/eks.aws.upbound.io_nodegroups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1715,12 +1715,7 @@ spec:
id.
type: string
version:
description: EC2 Launch Template version number. While the
API accepts values like $Default and $Latest, the API will
convert the value to the associated version number (e.g.,
1). Using the default_version or latest_version attribute
of the aws_launch_template resource or data source is recommended
for this argument.
description: EC2 Launch Template version number.
type: string
type: object
nodeRoleArn:
Expand Down Expand Up @@ -2190,12 +2185,7 @@ spec:
id.
type: string
version:
description: EC2 Launch Template version number. While the
API accepts values like $Default and $Latest, the API will
convert the value to the associated version number (e.g.,
1). Using the default_version or latest_version attribute
of the aws_launch_template resource or data source is recommended
for this argument.
description: EC2 Launch Template version number.
type: string
type: object
nodeRoleArn:
Expand Down Expand Up @@ -2833,12 +2823,7 @@ spec:
id.
type: string
version:
description: EC2 Launch Template version number. While the
API accepts values like $Default and $Latest, the API will
convert the value to the associated version number (e.g.,
1). Using the default_version or latest_version attribute
of the aws_launch_template resource or data source is recommended
for this argument.
description: EC2 Launch Template version number.
type: string
type: object
nodeRoleArn:
Expand Down
Loading