feat(s3): add s3 directory bucket #1429
Conversation
haarchri
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
haarchri
force-pushed
the
feature/s3-directory-bucket
branch
from
a26e0e8
to
01316ae
Compare
|
/test-examples="examples/s3/v1beta1/directorybucket.yaml" |
|
Hi all, is there any timeline on completing reviews? |
| location: | ||
| - name: usw2-az1 |
There was a problem hiding this comment.
This looks like a singleton list, which I'm surprised to see here. Perhaps the code which converts it into an embedded object only supports SDK resources, not framework?
Especially since this parameter should go into the external name config, I think we should do the necessary work to make this into an embedded object.
There was a problem hiding this comment.
@mbbush, location is indeed a singleton list. Our singleton list conversion implementation processes only Plugin SDK resources. Because Plugin Framework resource schema has a different structure (and type), singleton list detection and conversion should be implemented separately for it.
If I recall correctly though, singleton list fields shouldn't exist in Plugin Framework resources, in the first place, because Plugin Framework schema is able to represent them as embedded objects. Unfortunately, I can't remember why and how at the moment.
There was a problem hiding this comment.
A clarification… We traverse schemas of all resources, Plugin Framework and Plugin SDKv2, but our singleton list detector doesn't detect singleton lists of Plugin Framework schemas.
There was a problem hiding this comment.
We need to make changes on the upjet side to convert the singleton list to embedded object in the framework resources. I've created an issue for this on upjet, we can follow up from there.
Hi @PaulinaZaremba, thank you for your understanding and patience here. We are unable to include PR in this week's release in order to look at the issues mentioned in the reviews in more detail. We plan to cut a new release next week that includes this PR. |
|
/test-examples="examples/s3/v1beta1/directorybucket.yaml" |
turkenf
force-pushed
the
feature/s3-directory-bucket
branch
from
c7e4f5e
to
01316ae
Compare
Signed-off-by: Christopher Haar <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
turkenf
force-pushed
the
feature/s3-directory-bucket
branch
from
fa642fb
to
71f528f
Compare
|
/test-examples="examples/s3/v1beta1/directorybucket.yaml" |
Description of your changes
implement s3 directory bucket (aws_s3_directory_bucket)
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10618327577