Configure apprunner group, appstream group and add examples

[turkenf]

Description of your changes

This PR configures resources in the apprunner group and appstream group:

Apprunner group:

• aws_apprunner_auto_scaling_configuration_version
• aws_apprunner_connection
• aws_apprunner_service
• aws_apprunner_vpc_connector

Appstream group:

• aws_appstream_directory_config
• aws_appstream_fleet
• aws_appstream_fleet_stack_association
• aws_appstream_image_builder
• aws_appstream_stack
• aws_appstream_user
• aws_appstream_user_stack_association

Fixes: #10

Note: I couldn't configure aws_apprunner_custom_domain_association I reported an issue for this: #138

I have:

• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

aws_apprunner_auto_scaling_configuration_version: https://github.com/upbound/provider-aws/actions/runs/3481806772
aws_apprunner_connection: https://github.com/upbound/provider-aws/actions/runs/3481840093
aws_apprunner_service: https://github.com/upbound/provider-aws/actions/runs/3481882734
aws_apprunner_vpc_connector: https://github.com/upbound/provider-aws/actions/runs/3481915083
aws_appstream_directory_config: https://github.com/upbound/provider-aws/actions/runs/3481927600
aws_appstream_fleet: https://github.com/upbound/provider-aws/actions/runs/3481969926
aws_appstream_fleet_stack_association: https://github.com/upbound/provider-aws/actions/runs/3486771048
aws_appstream_image_builder: https://github.com/upbound/provider-aws/actions/runs/3482919880
aws_appstream_stack: https://github.com/upbound/provider-aws/actions/runs/3486287692
aws_appstream_user: https://github.com/upbound/provider-aws/actions/runs/3482964886
aws_appstream_user_stack_association: https://github.com/upbound/provider-aws/actions/runs/3514011471

[turkenf]

/test-examples="examples/apprunner/autoscalingconfigurationversion.yaml,examples/apprunner/connection.yaml,examples/apprunner/service.yaml,examples/apprunner/vpcconnector.yaml,examples/appstream/directoryconfig.yaml,examples/appstream/fleet.yaml,examples/appstream/fleetstackassociation.yaml,examples/appstream/imagebuilder.yaml,examples/appstream/stack.yaml,examples/appstream/user.yaml,examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/apprunner/autoscalingconfigurationversion.yaml,examples/apprunner/connection.yaml,examples/apprunner/service.yaml,examples/apprunner/vpcconnector.yaml,examples/appstream/directoryconfig.yaml,examples/appstream/fleet.yaml,examples/appstream/fleetstackassociation.yaml,examples/appstream/imagebuilder.yaml,examples/appstream/stack.yaml,examples/appstream/user.yaml,examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/apprunner/autoscalingconfigurationversion.yaml,examples/apprunner/connection.yaml,examples/apprunner/service.yaml,examples/apprunner/vpcconnector.yaml,examples/appstream/directoryconfig.yaml,examples/appstream/fleet.yaml,examples/appstream/fleetstackassociation.yaml,examples/appstream/imagebuilder.yaml,examples/appstream/stack.yaml,examples/appstream/user.yaml,examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/appstream/fleetstackassociation.yaml"

[turkenf]

/test-examples="examples/apprunner/autoscalingconfigurationversion.yaml,examples/apprunner/connection.yaml,examples/apprunner/service.yaml,examples/apprunner/vpcconnector.yaml,examples/appstream/directoryconfig.yaml,examples/appstream/fleet.yaml,examples/appstream/fleetstackassociation.yaml,examples/appstream/imagebuilder.yaml,examples/appstream/stack.yaml,examples/appstream/user.yaml,examples/appstream/userstackassociation.yaml"

[ulucinar]

Hi @turkenf,
Thank you for the PR!
Are the newly introduced example manifests testable on their own as a unit? Are they self-contained. i.e., each resource has its dependencies in its example manifest?

[turkenf]

@ulucinar thanks for the review, each example has its own dependencies and can be tested.

[ulucinar]

Hi @turkenf,
I've left some API normalization comments. Could you please check them? And could you please apply similar normalization changes to the other resources as well (if needed)?

Please also don't forget to retest the resources with configuration changes with uptest. A mapping from Terraform resource names to the uptest runs as in the description of PR #147 would be really helpful.

[turkenf]

/test-examples="examples/appstream/user.yaml,examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/apprunner/autoscalingconfigurationversion.yaml"

[turkenf]

/test-examples="examples/apprunner/connection.yaml"

[turkenf]

/test-examples="examples/apprunner/service.yaml"

[turkenf]

/test-examples="examples/apprunner/vpcconnector.yaml"

[turkenf]

/test-examples="examples/appstream/directoryconfig.yaml"

[turkenf]

/test-examples="examples/appstream/fleet.yaml"

[turkenf]

/test-examples="examples/appstream/fleetstackassociation.yaml"

[turkenf]

/test-examples="examples/appstream/imagebuilder.yaml"

[turkenf]

/test-examples="examples/appstream/stack.yaml"

[turkenf]

/test-examples="examples/appstream/user.yaml"

[turkenf]

/test-examples="examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/appstream/stack.yaml"

[turkenf]

/test-examples="examples/appstream/fleetstackassociation.yaml"

[turkenf]

/test-examples="examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/appstream/userstackassociation.yaml"

[turkenf]

/test-examples="examples/appstream/userstackassociation.yaml"

[turkenf]

This PR is ready for review.

[turkenh]

Having serviceName as a parameter instead of using metadata.name does not look intuitive.

However, I believe there is no way to achieve this currently since the external name contains a randomly generated string by the provider. Crosslinking the related issue here: crossplane/upjet#142