Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add port to connection details #1460

Conversation

aiell0
Copy link
Contributor

@aiell0 aiell0 commented Aug 15, 2024

Description of your changes

Fixes #1458

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested with uptest and manually commented below

@aiell0 aiell0 force-pushed the add-port-to-elasticache-connection-details branch from cc54ae3 to 569e5fd Compare August 15, 2024 02:43
@aiell0
Copy link
Contributor Author

aiell0 commented Aug 15, 2024

/test-examples="examples/opensearch/v1beta1/domain.yaml"

@aiell0
Copy link
Contributor Author

aiell0 commented Aug 15, 2024

/test-examples="examples/opensearch/v1beta2/domain.yaml"

@aiell0
Copy link
Contributor Author

aiell0 commented Aug 20, 2024

/test-examples="examples/elasticache/v1beta1/cluster.yaml"

@aiell0
Copy link
Contributor Author

aiell0 commented Aug 20, 2024

/test-examples="examples/elasticache/v1beta2/cluster.yaml"

@aiell0 aiell0 requested a review from turkenf August 20, 2024 21:32
@aiell0
Copy link
Contributor Author

aiell0 commented Aug 20, 2024

/test-examples="examples/elasticache/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 21, 2024

Thank you for your effort, @aiell0; it would be great if you could update the description to show that you are testing manually and seeing the port value in the secret.

@aiell0
Copy link
Contributor Author

aiell0 commented Aug 22, 2024

@turkenf I had to change the code to reflect the correct type of port (number vs string) and it worked! Result is below:

lawrenceaiello@Lawrences-MacBook-Pro ~/Development/aiell0/provider-upjet-aws (add-port-to-elasticache-connection-details) $ k get secrets                                                                                                 <aws:dev>
NAME             TYPE                                DATA   AGE
sample-cluster   connection.crossplane.io/v1alpha1   2      7m14s
lawrenceaiello@Lawrences-MacBook-Pro ~/Development/aiell0/provider-upjet-aws (add-port-to-elasticache-connection-details) $ k describe secrets                                                                                            <aws:dev>
Name:         sample-cluster
Namespace:    default
Labels:       <none>
Annotations:  <none>

Type:  connection.crossplane.io/v1alpha1

Data
====
cluster_address:  50 bytes
port:             5 bytes
lawrenceaiello@Lawrences-MacBook-Pro ~/Development/aiell0/provider-upjet-aws (add-port-to-elasticache-connection-details) $ kubectl get secret sample-cluster -o jsonpath="{.data.port}" | base64 --decode
11211

@aiell0 aiell0 force-pushed the add-port-to-elasticache-connection-details branch from bf26973 to 3e6ba3c Compare August 22, 2024 03:45
@aiell0
Copy link
Contributor Author

aiell0 commented Aug 22, 2024

/test-examples="examples/elasticache/v1beta1/cluster.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aiell0, LGTM.

@turkenf turkenf merged commit f179daf into crossplane-contrib:main Aug 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElastiCache Clusters write endpoint to secret
4 participants