-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add port to connection details #1460
chore: add port to connection details #1460
Conversation
cc54ae3
to
569e5fd
Compare
/test-examples="examples/opensearch/v1beta1/domain.yaml" |
/test-examples="examples/opensearch/v1beta2/domain.yaml" |
/test-examples="examples/elasticache/v1beta1/cluster.yaml" |
/test-examples="examples/elasticache/v1beta2/cluster.yaml" |
/test-examples="examples/elasticache/v1beta1/cluster.yaml" |
Thank you for your effort, @aiell0; it would be great if you could update the description to show that you are testing manually and seeing the port value in the secret. |
@turkenf I had to change the code to reflect the correct type of port (number vs string) and it worked! Result is below:
|
Signed-off-by: aiell0 <[email protected]>
Signed-off-by: Elliot West <[email protected]> Signed-off-by: aiell0 <[email protected]>
Signed-off-by: aiell0 <[email protected]>
Signed-off-by: aiell0 <[email protected]>
bf26973
to
3e6ba3c
Compare
/test-examples="examples/elasticache/v1beta1/cluster.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aiell0, LGTM.
Description of your changes
Fixes #1458
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Tested with uptest and manually commented below