Moving accessanalyzer (1),account (1), amplify (4) resources to v1beta1 version #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/accessanalyzer/analyzer.yaml" |
|
/test-examples="examples/account/alternatecontact.yaml" |
|
/test-examples="examples/amplify/app.yaml" |
|
/test-examples="examples/amplify/backendenvironment.yaml" |
|
/test-examples="examples/amplify/branch.yaml" |
|
/test-examples="examples/amplify/webhook.yaml" |
turkenh
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Looking great, thanks @svscheg!
Two requests before merge:
- Please rebase your PR on top of latest main. There is a conflict after getting a couple of PRs merged.
- Could you add some more details on
How has this code been testedsection? Similar to Add 6 aws appmesh services #147
svscheg
force-pushed
the
moving-accessanalyzer-account-amplify
branch
from
7391d21
to
1547298
Compare
svscheg
force-pushed
the
moving-accessanalyzer-account-amplify
branch
from
1547298
to
f94b16c
Compare
|
/test-examples="examples/accessanalyzer/analyzer.yaml" |
|
/test-examples="examples/account/alternatecontact.yaml" |
|
/test-examples="examples/amplify/app.yaml" |
|
/test-examples="examples/amplify/backendenvironment.yaml" |
|
/test-examples="examples/amplify/branch.yaml" |
|
/test-examples="examples/amplify/webhook.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Moving accessanalyzer (1),account (1), amplify (4) resources to v1beta1 version.
Moving 1 resource in the
accessanalyzergroup:aws_accessanalyzer_analyzerMoving 1 resource in the
accountgroup:aws_account_alternate_contactMoving 4 resources in the
amplifygroup:aws_amplify_appaws_amplify_backend_environmentaws_amplify_branchaws_amplify_webhookFixes #71
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually and Uptest.
aws_accessanalyzer_analyzer- https://github.com/upbound/provider-aws/actions/runs/3522156683/jobs/5904803364aws_account_alternate_contact- https://github.com/upbound/provider-aws/actions/runs/3522158119/jobs/5904806470aws_amplify_app- https://github.com/upbound/provider-aws/actions/runs/3522162150/jobs/5904814752aws_amplify_backend_environment- https://github.com/upbound/provider-aws/actions/runs/3522164390/jobs/5904819662aws_amplify_branch- https://github.com/upbound/provider-aws/actions/runs/3522165753/jobs/5904822157aws_amplify_webhook- https://github.com/upbound/provider-aws/actions/runs/3522166942/jobs/5904825079