Increase claim scheduling and defaulting max jitter to 1.5 seconds

200ms seems low enough that GCP consistently beats Azure when scheduling RedisCluster claims in my experiments. Signed-off-by: Nic Cope <[email protected]>
crossplane · Oct 22, 2019 · 8faf79f · 8faf79f
1 parent aafb516
commit 8faf79f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/pkg/resource/claim_defaulting_reconciler.go b/pkg/resource/claim_defaulting_reconciler.go
@@ -34,8 +34,9 @@ import (
 )
 
 const (
-	claimDefaultingControllerName   = "resourceclaimdefaulter.crossplane.io"
-	claimDefaultingReconcileTimeout = 1 * time.Minute
+	claimDefaultingControllerName       = "resourceclaimdefaulter.crossplane.io"
+	claimDefaultingReconcileTimeout     = 1 * time.Minute
+	claimDefaultingReconcileMaxJitterMs = 1500
 )
 
 // A ClaimDefaultingReconciler reconciles resource claims by setting their
@@ -75,7 +76,7 @@ func NewClaimDefaultingReconciler(m manager.Manager, of ClaimKind, to ClassKind,
 		classKind: to,
 		jitter: func() {
 			random := rand.New(rand.NewSource(time.Now().UnixNano()))
-			time.Sleep(time.Duration(random.Intn(200)) * time.Millisecond)
+			time.Sleep(time.Duration(random.Intn(claimDefaultingReconcileMaxJitterMs)) * time.Millisecond)
 		},
 	}
 

diff --git a/pkg/resource/claim_scheduling_reconciler.go b/pkg/resource/claim_scheduling_reconciler.go
@@ -33,8 +33,9 @@ import (
 )
 
 const (
-	claimSchedulingControllerName   = "resourceclaimscheduler.crossplane.io"
-	claimSchedulingReconcileTimeout = 1 * time.Minute
+	claimSchedulingControllerName       = "resourceclaimscheduler.crossplane.io"
+	claimSchedulingReconcileTimeout     = 1 * time.Minute
+	claimSchedulingReconcileMaxJitterMs = 1500
 )
 
 const (
@@ -85,7 +86,7 @@ func NewClaimSchedulingReconciler(m manager.Manager, of ClaimKind, to ClassKind,
 		classKind: to,
 		jitter: func() {
 			random := rand.New(rand.NewSource(time.Now().UnixNano()))
-			time.Sleep(time.Duration(random.Intn(200)) * time.Millisecond)
+			time.Sleep(time.Duration(random.Intn(claimSchedulingReconcileMaxJitterMs)) * time.Millisecond)
 		},
 	}