Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate webhook functions for fields with +immutable comment tag #40

Open
muvaf opened this issue Mar 16, 2022 · 2 comments
Open

Generate webhook functions for fields with +immutable comment tag #40

muvaf opened this issue Mar 16, 2022 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@muvaf
Copy link
Member

muvaf commented Mar 16, 2022

What problem are you facing?

Webhooks are available in Crossplane now and immutability check on UPDATE action is implemented manually for each field.

How could Crossplane help solve your problem?

Similar to reference resolver generation, we can have a generator in crossplane-tools that will scan the fields for // +immutable tag and generate the logic automatically.
@muvaf muvaf added the enhancement New feature or request label Mar 16, 2022
@muvaf muvaf mentioned this issue Mar 16, 2022
Closed
@muvaf muvaf mentioned this issue Mar 28, 2022
Open
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2022
@muvaf muvaf mentioned this issue Aug 24, 2022
Open
@negz
Copy link
Member

negz commented Sep 7, 2022 •
edited
Loading

We might also be able to do this with CEL now per kubernetes/kubernetes#65973 (comment). See also kubernetes/website#36032.

@negz negz mentioned this issue Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@negz @muvaf