-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post: Immutability patterns using CEL #36032
Conversation
40b0702
to
6f8322a
Compare
6f8322a
to
546d1d7
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The article should be in the future - how about mid-September, after the v1.25 post-release articles are out?
/hold
Two style tweaks I recommend:
- Use sentence case for headings within the Markdown
- Don't include the command prompt
- Write in first person singular (or, where appropriate, address the reader as you).
Plus, some inline feedback.
Thanks Tim for looking it over and helping the article look better! I've incorporated your tips everywhere I could find with the exception of the mermaid diagram for the folder structure which I've followed up on in the comment.
I am not familiar with how the articles names/metadata apply to the timing of their release. Does this require the file to be renamed and the date changed within? |
Yes, please. |
Usage of CEL within Kubernetes Validation Rules is so much more powerful than | ||
what has been shown in this article. For more information please check out | ||
[validation rules](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-rules) | ||
in the Kubernetes documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also link to the blog that #35459 will publish, and we could amend that article to link to this one (would need us to delay merging this PR, so that we don't link to a not-yet-published article).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to a prospective URL added. Agreed hold until link is confirmed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a link to https://kubernetes.io/blog/2022/09/23/crd-validation-rules-beta/
I suggest publication on the 29th of September. |
@katcosgrove how does that date sound to you? |
@sftim Fine by me -- I'll add it to the spreadsheet. Thanks! |
/hold cancel |
This looks like a thought-through article. I haven't tested that it's technically correct; I think it'll be good to publish based on circumstantial evidence around the quality of writing. I'd have liked to see this PR make an update to https://kubernetes.io/blog/2022/09/23/crd-validation-rules-beta/, so that https://kubernetes.io/blog/2022/09/23/crd-validation-rules-beta/ links to the new article. Anyway, let's ship it. /lgtm |
LGTM label has been added. Git tree hash: fd80310c6540b00bac0686a6d6a60c6ec261178a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a post expanding upon #35459 which walks a reader through how to use kubebuilder marker comments to enforce common immutability design patterns.