Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support simple resource class selection #7

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Conversation

negz
Copy link
Member

@negz negz commented Oct 17, 2019

crossplane/crossplane#926
crossplane/crossplane#927
crossplane/crossplane-runtime#48

Updates angryjet to reflect the above changes.

Description of your changes

Checklist

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Ensured this PR contains a neat, self documenting set of commits.

Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about incorporating #2 into this PR? Just thinking that if we are going to bump stack dependencies that it might be nice to only have to do so once. Otherwise, LGTM!

@negz
Copy link
Member Author

negz commented Oct 17, 2019

How would you feel about incorporating #2 into this PR?

I agree with the sentiment, but I'm inclined to tackle it in a separate PR because it's a slightly less trivial change than it might seem. angryjet doesn't know how to write anything but methods at the moment, so we'd probably have to teach generate.WriteMethods how to know whether the methods it was writing should satisfy an interface.

Copy link
Contributor

@soorena776 soorena776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@soorena776
Copy link
Contributor

@negz FYI, my changes also have a change in the api (adding GetCondition), so you might want to wait until that is checked in, if you don't want to open another pr later

@negz
Copy link
Member Author

negz commented Oct 17, 2019

@soorena776 Thanks for the heads up. My suspicion is it might be best to add your changes in a separate PR, because it might take me a while to merge this one.

@hasheddan
Copy link
Member

I agree with the sentiment, but I'm inclined to tackle it in a separate PR because it's a slightly less trivial change than it might seem.

@negz sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants