Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Usage replayDeletion #728

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Mar 9, 2024

Documenting the configuration introduced by crossplane/crossplane#5394

Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 3e02cbb
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/65ec75933a5ba70008f411ee
😎 Deploy Preview https://deploy-preview-728--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🟢 up 5 from production)
Accessibility: 88 (🔴 down 3 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Hasan Turken <[email protected]>

By default, the deletion of a `Usage` resource doesn't trigger the deletion of
the resource in use even if there were deletion attempts blocked by the `Usage`.
Replaying the blocked deletion is possible by setting the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "replaying" the way to get kubernetes to try and delete the resource again after the usage is removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage protects by blocking the deletion of the used resource as long as there are using resources.

Unfortunately, Kubernetes garbage collection backoffs up to 15 mins and there seems to be no way to reset this backoff.

"replaying" is sending a delete request to the used resource when the Usage is gone iff there was a blocked delete request.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest an edit to be more explicit about that here, something like

Use {{}}replayDeletion: true{{}} to immediately create send a deletion request to Kubernetes instead of waiting for the Kubernetes backoff.

Feel free to reword, I'd just make it more obvious that "doing this makes deletion happen faster"

content/master/concepts/usages.md Show resolved Hide resolved
@turkenh turkenh requested a review from plumbis March 11, 2024 20:25
@plumbis plumbis merged commit 5fb0dbb into crossplane:master Mar 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants