Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

[BUG] delete component and modify appConfig's components to null array lead to panic #327

Closed
xishengcai opened this issue Apr 20, 2021 · 0 comments · Fixed by #329
Closed

[BUG] delete component and modify appConfig's components to null array lead to panic #327

xishengcai opened this issue Apr 20, 2021 · 0 comments · Fixed by #329

Comments

@xishengcai
Copy link
Contributor

Describe the bug

To Reproduce

  1. deploy oam latest version
  2. kubectl apply -f examples/containerized-workload/
  3. kubectl delete component example-component
  4. modify applicationconfiguration: example-appconfig. spec.components: []

Expected behavior
expect deployment deleted

Screenshots
image

Cluster information

  • Kubernetes Version : 1.17
@xishengcai xishengcai changed the title [BUG] delete component lead to panic [BUG] delete component and modify appConfig's components to null array lead to panic Apr 20, 2021
xishengcai pushed a commit to xishengcai/oam-kubernetes-runtime that referenced this issue Apr 20, 2021
fix bug issue crossplane#327
2c4ea47
xishengcai pushed a commit to xishengcai/oam-kubernetes-runtime that referenced this issue Apr 20, 2021
fix bug crossplane#327
c12c48f 
delete component and modify appConfig's components to null array lead to panic
@yangsoon yangsoon mentioned this issue Apr 20, 2021
Merged
xishengcai pushed a commit to xishengcai/oam-kubernetes-runtime that referenced this issue Apr 20, 2021
fix bug fix bug crossplane#327
a8827b3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix contorller: check the number of workloads before applying workloads
1 participant
@xishengcai