This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
add revisions garbage collection mechanism #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erdun
commented
Aug 2, 2020
•
erdun
commented
- add revisions garbage collection mechanism, default revision limit is 50.
- revision in use won't be deleted
erdun
force-pushed
the
revision
branch
2 times, most recently
from
72bc7bf
to
ace7cd5
Compare
wonderflow
reviewed
Aug 3, 2020
Signed-off-by: erdun <[email protected]>
Signed-off-by: erdun <[email protected]>
wonderflow
changed the title
|
LGTM |
ryanzhang-oss
approved these changes
Aug 25, 2020
| } | ||
| } | ||
|
|
||
| toKeep := revisionLimit + len(liveHashes) |
There was a problem hiding this comment.
where is toKeep used other than immediately below?
| continue | ||
| } | ||
| // Clean up | ||
| revisionToClean := revision |
There was a problem hiding this comment.
same, why creating another variable?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.