Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

fix directly return when appconfig has multiple scope to attach #188

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

captainroy-hy
Copy link
Contributor

@captainroy-hy captainroy-hy commented Aug 28, 2020

fixes #187
add e2e-test & modify unit test

Signed-off-by: roy wang [email protected]

add e2e-test & modify unit test

Signed-off-by: roy wang <[email protected]>
Copy link
Member

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow changed the title fix issue#187 fix directly return when appconfig has multiple scope to attach Aug 28, 2020
@wonderflow wonderflow merged commit 9fe3668 into crossplane:master Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot apply all components in one AppConfig
2 participants