This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
add labels for workload to record component info #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add e2e test & unit test Signed-off-by: roy wang <[email protected]>
wonderflow
approved these changes
Aug 29, 2020
wonderflow
reviewed
Aug 29, 2020
| oam.LabelAppComponent: acc.ComponentName, | ||
| oam.LabelAppComponentRevision: componentRevisionName, | ||
| } | ||
| w.SetLabels(labels) |
There was a problem hiding this comment.
please make sure we won't override the existing labels.
There was a problem hiding this comment.
sure, I will use merge instead of override here.
add unit test Signed-off-by: roy wang <[email protected]>
| @@ -469,6 +477,17 @@ func fillValue(obj *unstructured.Unstructured, fs []string, val interface{}) err | |||
| return nil | |||
| } | |||
|
|
|||
| func addWorkloadLabels(w *unstructured.Unstructured, labels map[string]string) { | |||
There was a problem hiding this comment.
can you move this to util and change the name from "addWorkloadLabels" to "addLabels" as this is very generic. Also, I am not sure if this already exists somewhere in the library
There was a problem hiding this comment.
Yes, I will check and move it.
Signed-off-by: roy wang <[email protected]>
|
Good job |
This was referenced Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: roy wang [email protected]