This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
feat(component):Add observedGeneration to represent Component #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add observedGeneration to represent Component Fix crossplane#91 Signed-off-by: zhuhuijun <[email protected]>
wonderflow
reviewed
Sep 14, 2020
wonderflow
reviewed
Sep 14, 2020
|
copy |
Ghostbaby
added a commit
to Ghostbaby/oam-kubernetes-runtime
that referenced
this pull request
Sep 16, 2020
Add observedGeneration to represent Component Fix crossplane#205 Signed-off-by: zhuhuijun <[email protected]>
Ghostbaby
added a commit
to Ghostbaby/oam-kubernetes-runtime
that referenced
this pull request
Sep 16, 2020
Add observedGeneration to represent Component Fix crossplane#205 Signed-off-by: zhuhuijun <[email protected]>
Ghostbaby
force-pushed
the
feat_observedGeneration
branch
from
233659f
to
bc182db
Compare
wonderflow
suggested changes
Sep 17, 2020
pkg/controller/v1alpha2/applicationconfiguration/applicationconfiguration.go
Show resolved
Hide resolved
Add observedGeneration to represent Component Fix crossplane#205 Signed-off-by: zhuhuijun <[email protected]>
Ghostbaby
force-pushed
the
feat_observedGeneration
branch
from
bc182db
to
263dd2a
Compare
wonderflow
reviewed
Sep 27, 2020
pkg/controller/v1alpha2/applicationconfiguration/applicationconfiguration_test.go
Outdated
Show resolved
Hide resolved
wonderflow
approved these changes
Sep 27, 2020
Signed-off-by: zhuhuijun <[email protected]>
…ration Signed-off-by: zhuhuijun <[email protected]>
…ration Signed-off-by: zhuhuijun <[email protected]>
Signed-off-by: zhuhuijun <[email protected]>
| @@ -228,6 +228,7 @@ func (r *OAMApplicationReconciler) Reconcile(req reconcile.Request) (result reco | |||
|
|
|||
| // execute the posthooks at the end no matter what | |||
| defer func() { | |||
| updateObservedGeneration(ac) | |||
There was a problem hiding this comment.
An afterthought: I don't think this is the right place to update ObservedGeneration. Because this will always update even if the reconciliation failed.
Note that I will be fixing this shortly.
There was a problem hiding this comment.
Reconcile failed also need to add observed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add observedGeneration to represent Component
Fix #91
Signed-off-by: zhuhuijun [email protected]