This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
add version into definitionReference for workload/trait/scope definitions #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PartialResource: gvr, | ||
| } | ||
| } | ||
| return kinds[0], nil |
There was a problem hiding this comment.
I am not sure that this is a good assumption. How can there be multiple kinds when the version is set?
There was a problem hiding this comment.
This is used for cases whose version was not set.
…ions Signed-off-by: 天元 <[email protected]>
| @@ -297,6 +299,23 @@ func GetDefinitionName(dm discoverymapper.DiscoveryMapper, u *unstructured.Unstr | |||
| return mapping.Resource.Resource + "." + groupVersion.Group, nil | |||
| } | |||
|
|
|||
| // GetGVKFromDefinition help get Group Version Kind from DefinitionReference | |||
| func GetGVKFromDefinition(dm discoverymapper.DiscoveryMapper, definitionRef v1alpha2.DefinitionReference) (schema.GroupVersionKind, error) { | |||
There was a problem hiding this comment.
I don't see any place that uses this method.
There was a problem hiding this comment.
Could you provide an example how this is gonna be used?
I mean real use cases, not tests.
There was a problem hiding this comment.
sorry, I added one in the code.
hongchaodeng
approved these changes
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #210
Signed-off-by: 天元 [email protected]