crossterm_utils fixes #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Vojta <[email protected]>
TimonPost
reviewed
Sep 13, 2019
There was a problem hiding this comment.
Nice work, I don't think we should mention crossterm_terminal, crossterm_cursor in the docstrings.
- when a user uses the crossterm crate, all types are reexported, and thus they belong to the crossterm namespace instead of crossterm_cursor/terminal.
- utils is not supposed to know anything about cursor and terminal. I can see a valid usecase for demonstration purposes, so we either use the commands from
crossterm_utilslikeOutputor we show types from cursor or terminal. But do we really need that dependency?
Signed-off-by: Robert Vojta <[email protected]>
Signed-off-by: Robert Vojta <[email protected]>
Merged
TimonPost
approved these changes
Sep 14, 2019
december1981
pushed a commit
to december1981/crossterm
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cd crossterm_utils && cargo testis passing.