Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
[Password Generation] Fix a bug where we always upload ACCOUNT_CREATI…
Browse files Browse the repository at this point in the history
…ON_PASSWORD

Update test to catch the problem. Previous test mocked out
bad behavior.

BUG=419228
[email protected]

Review URL: https://codereview.chromium.org/614313002

Cr-Commit-Position: refs/heads/master@{#297580}
  • Loading branch information
Garrett Casto committed Oct 1, 2014
1 parent 83988d7 commit 44c5e4e
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,7 @@ void PasswordFormManager::UploadPasswordForm(
// Note that this doesn't guarantee that the upload succeeded, only that
// |form_data| is considered uploadable.
bool success =
autofill_manager->UploadPasswordForm(
form_data, autofill::ACCOUNT_CREATION_PASSWORD);
autofill_manager->UploadPasswordForm(form_data, password_type);
UMA_HISTOGRAM_BOOLEAN("PasswordGeneration.UploadStarted", success);
}

Expand Down

0 comments on commit 44c5e4e

Please sign in to comment.