Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
Hack for AIA fetching on Mac Sierra: On >=10.12, always do FETCH_CRL_…
Browse files Browse the repository at this point in the history
…FROM_NET if adding a crl policy.

BUG=645629

Review-Url: https://codereview.chromium.org/2368453002
Cr-Commit-Position: refs/heads/master@{#420482}
  • Loading branch information
matt-mueller authored and Commit bot committed Sep 22, 2016
1 parent d96e270 commit 97a93ce
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion net/cert/x509_util_mac.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "net/cert/x509_util_mac.h"

#include "base/logging.h"
#include "base/mac/mac_util.h"
#include "third_party/apple_apsl/cssmapplePriv.h"

namespace net {
Expand Down Expand Up @@ -100,7 +101,9 @@ OSStatus CreateRevocationPolicies(bool enable_revocation_checking,
// online revocation checking. Note that, as of OS X 10.7.2, the system
// will set force this flag on according to system policies, so
// online revocation checks cannot be completely disabled.
if (enable_revocation_checking)
// Starting with OS X 10.12, if a CRL policy is added without the
// FETCH_CRL_FROM_NET flag, AIA fetching is disabled.
if (enable_revocation_checking || base::mac::IsAtLeastOS10_12())
tp_crl_options.CrlFlags = CSSM_TP_ACTION_FETCH_CRL_FROM_NET;

SecPolicyRef crl_policy;
Expand Down

0 comments on commit 97a93ce

Please sign in to comment.