Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
Android Media Notification: remove "Touch to return" text.
Browse files Browse the repository at this point in the history
The notification only shows the origin. Touching the notification to
return to the playing application is a very common pattern on Android.
It is not required for us to reinforce it with text, making the
notification less appealing.

BUG=528202

Review URL: https://codereview.chromium.org/1326163002

Cr-Commit-Position: refs/heads/master@{#347377}
  • Loading branch information
mounirlamouri authored and Commit bot committed Sep 4, 2015
1 parent 5e94485 commit ded797a
Showing 1 changed file with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -346,14 +346,6 @@ private String sanitizeMediaTitle(String title) {
return title.startsWith("\u25B6") ? title.substring(1).trim() : title;
}

private String getStatus() {
if (mMediaNotificationInfo.origin != null) {
return mContext.getString(R.string.media_notification_link_text,
mMediaNotificationInfo.origin);
}
return mContext.getString(R.string.media_notification_text_no_link);
}

private PendingIntent createContentIntent() {
int tabId = mMediaNotificationInfo.tabId;
return PendingIntent.getActivity(
Expand Down Expand Up @@ -411,7 +403,7 @@ private void updateNotification() {
RemoteViews contentView = createContentView();

contentView.setTextViewText(R.id.title, mMediaNotificationInfo.title);
contentView.setTextViewText(R.id.status, getStatus());
contentView.setTextViewText(R.id.status, mMediaNotificationInfo.origin);
if (mNotificationIcon != null) {
contentView.setImageViewBitmap(R.id.icon, mNotificationIcon);
} else {
Expand Down

0 comments on commit ded797a

Please sign in to comment.