[Temp] Make unix socket Get{Peer|Local}Address return more rational errors.

[wuhengzhi]

Rather than return ERR_NOT_IMPLEMENTED it seems sensible to
return ERR_SOCKET_NOT_CONNECTED in the case that the socket
is not connected, but unconditionally return ERR_ADDRESS_INVALID
if connected (because there's no IP addr or port associated
with either end of the socket).

BUG=431412

Review URL: https://codereview.chromium.org/841993002

Cr-Commit-Position: refs/heads/master@{#310564}

[crosswalk-trybot]

Testing patch series with wuhengzhi/chromium-crosswalk@b485241 as its head.

Bot	Status
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/147)
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/148)

[wang16]

I don't think it's the right way to do this. You need to find out how crosswalk uses UnixDomainSocket and provide crosswalk's implementation, even it's an empty impl.

[wuhengzhi]

I have the same opinion, but in the call stack, UnixDomainSocket() was called in net/server/http_server.cc

#0  net::UnixDomainClientSocket::GetPeerAddress (this=0x691ee570, address=0x673f87a0) at ../../net/socket/unix_domain_client_socket_posix.cc:101
#1  0x61a5f0e0 in net::HttpServer::HandleReadResult (this=0x672dfcf0, connection=0x6744c030, rv=1732216736) at ../../net/server/http_server.cc:235
#2  0x61a5f747 in net::HttpServer::OnReadCompleted (this=0x672dfcf0, connection_id=1155, rv=22) at ../../net/server/http_server.cc:195
#3  0x61a5e633 in Run (a1=<optimized out>, a2=<optimized out>, object=<optimized out>, this=<synthetic pointer>) at ../../base/bind_internal.h:248
#4  MakeItSo (a3=@0x673f88ac: 22, a2=@0x680f255c: 1155, weak_ptr=base::WeakPtr((net::HttpServer *)0x672dfcf0), runnable=...) at ../../base/bind_internal.h:938
#5  base::internal::Invoker<2, base::internal::BindState<base::internal::RunnableAdapter<void (net::HttpServer::*)(int, int)>, void (net::HttpServer*, int, int), void (base::WeakPtr<net::HttpServer>, int)>, void (net::HttpServer*, int, int)>::Run(base::internal::BindStateBase*, int const&) (base=0x680f2540, x3=@0x673f88ac: 22) at ../../base/bind_internal.h:1349
#6  0x5fa489af in Run (a1=<optimized out>, this=<optimized out>) at ../../base/callback.h:441
#7  net::SocketLibevent::ReadCompleted (this=0x68190194) at ../../net/socket/socket_libevent.cc:433
#8  0x5fa4955e in net::SocketLibevent::OnFileCanReadWithoutBlocking (this=0x68190150, fd=118) at ../../net/socket/socket_libevent.cc:350
#9  0x5f7ebfaf in base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking (this=0x68190178, fd=118, pump=0x672e97e0) at ../../base/message_loop/message_pump_libevent.cc:99
#10 0x5f7ec1a0 in base::MessagePumpLibevent::OnLibeventNotification (fd=118, flags=2, context=0x673f8a68) at ../../base/message_loop/message_pump_libevent.cc:354
#11 0x5f87f723 in event_process_active (base=<optimized out>) at ../../third_party/libevent/event.c:373
#12 event_base_loop (base=0x672e9840, flags=1) at ../../third_party/libevent/event.c:513
#13 0x5f7eaed3 in base::MessagePumpLibevent::Run (this=0x672e97e0, delegate=0x672e9290) at ../../base/message_loop/message_pump_libevent.cc:259
#14 0x5f834db4 in base::MessageLoop::RunHandler (this=0x672e9290) at ../../base/message_loop/message_loop.cc:415
#15 0x5f84db48 in base::RunLoop::Run (this=0x673f8d18) at ../../base/run_loop.cc:55
#16 0x5f832aeb in base::MessageLoop::Run (this=0x672e9290) at ../../base/message_loop/message_loop.cc:308
#17 0x5f867eb9 in base::Thread::Run (this=0x672dfc70, message_loop=0x672e9290) at ../../base/threading/thread.cc:174
#18 0x5f868a34 in base::Thread::ThreadMain (this=0x672dfc70) at ../../base/threading/thread.cc:228
#19 0x5f863275 in base::(anonymous namespace)::ThreadFunc (params=0x65a4c510) at ../../base/threading/platform_thread_posix.cc:80

[wuhengzhi]

how crosswalk uses UnixDomainSocket, you mean how upstream? We can extend StreamSocket and implement UnixDomainSocket(), then change the socket in HttpConnection, I am afraid this will affect the other processes.

[wang16]

net module always takes UnixDomainSocket as param for sure, but crosswalk could provide XWalkUnixDomainSocket. I remember android webview provides AndroidUnixDomainSocket, we could do similar.

[halton]

This error message is also available on upstream Android build. Why it is trouble for Crosswalk?

[wang16]

customer reported that it makes logcat useless.

[halton]

I'd agree this logcat is useless, same pain on me when I try to debug Crosswalk on Android. I think it is low priority and I'd suggest to discuss with upstream for fix. Removing this in our fork is last solution.

[wang16]

upstream has derived implementation for chrome and android webview. I don't think they care so much about content shell. We should adopt there approach for chrome/webview.

[halton]

upstream has derived implementation for chrome and android webview. I don't think they care so much about content shell. We should adopt there approach for chrome/webview.

Agreed, that is right solution.

[crosswalk-trybot]

Testing patch series with wuhengzhi/chromium-crosswalk@6dd62e7 as its head.

Bot	Status
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/153)
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/152)

[halton]

lgtm with nit, use [Temp] prefix in git log to indicate rebase owner to remove it in future.

[wang16]

LGTM after fix halton's comment, thanks.

[wuhengzhi]

I will add it, thanks.

[crosswalk-trybot]

Testing patch series with wuhengzhi/chromium-crosswalk@44a8a9c as its head.

Bot	Status
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/153)
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/154)

[rakuco]

Make sure to roll DEPS.xwalk, and possibly backport this to crosswalk-11.