Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Temp] Export ui::NativeDisplayDelegateOzone. #226

Merged
merged 1 commit into from
Jan 8, 2015
Merged

[Temp] Export ui::NativeDisplayDelegateOzone. #226

merged 1 commit into from
Jan 8, 2015

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Jan 8, 2015

This class is used by ozone-wayland, but building Crosswalk with
-Dcomponent=shared_library causes linking to fail because this symbol is
not exported by libozone.so even though it is referenced in
libwayland.so.

The best approach upstream is still being discussed, including using a
different class in ozone-wayland. For now, we need it for XWALK-2571, as
building Crosswalk in shared library mode is part of the solution for
it.

@rakuco
[Temp] Export ui::NativeDisplayDelegateOzone.
60bd47d 
This class is used by ozone-wayland, but building Crosswalk with
-Dcomponent=shared_library causes linking to fail because this symbol is
not exported by libozone.so even though it is referenced in
libwayland.so.

The best approach upstream is still being discussed, including using a
different class in ozone-wayland. For now, we need it for XWALK-2571, as
building Crosswalk in shared library mode is part of the solution for
it.
@crosswalk-trybot
Copy link

Testing patch series with rakuco/chromium-crosswalk@60bd47d as its head.

Bot Status
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/151)
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/152)

@rakuco
Copy link
Member Author

rakuco commented Jan 8, 2015

@darktears @kalyankondapally

rakuco added a commit that referenced this pull request Jan 8, 2015
@rakuco
Merge pull request #226 from rakuco/export-NativeDisplayDelegateOzone
5c8891d 
[Temp] Export ui::NativeDisplayDelegateOzone.
@rakuco rakuco merged commit 5c8891d into crosswalk-project:master Jan 8, 2015
@rakuco rakuco deleted the export-NativeDisplayDelegateOzone branch January 8, 2015 13:39
mrunalk pushed a commit that referenced this pull request Jan 27, 2015
@quisquous
cc: Fix integer overflow when picking raster scales
047ed09 
This fixes a bug on flickr maps during a zoom out scale animation on a
composited layer.  It has an animation with a maximum scale of 16384
and, due to integer overflow, this failed the check that the scaled area
was less than the viewport size.  It would then pick 16384 as the
maximum animation scale, create a tiling at this scale, attempt to
create too many tiles, and run out of memory eventually.

Boo, integer overflows.  Yay, 64-bit math.

[email protected]
BUG=437452

Review URL: https://codereview.chromium.org/761583004

Cr-Commit-Position: refs/heads/master@{#306757}
(cherry picked from commit e03ed16)

Review URL: https://codereview.chromium.org/774393003

Cr-Commit-Position: refs/branch-heads/2214@{#226}
Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco pushed a commit that referenced this pull request Feb 27, 2015
[Merge 41] Make PointerDeviceObserver work under Ozone
bdaa5cf 
This CL:
- Makes PointerDeviceObserver get notified when a mouse or touchpad is
  plugged in or removed by making PointerDeviceObserver an
  InputDeviceEventObserver on ozone only.
- Adds InputDeviceEventObserver::OnMouseDeviceConfigurationChanged() and
       InputDeviceEventObserver::OnTouchpadDeviceConfigurationChanged().
- Adds the plumbing from EventFactoryEvdev to notify
  InputDeviceEventObservers when a mouse or touchpad is plugged in or
  removed.

In a later CL I will make PointerDeviceObserver an InputDeviceEventObserver on
X11 and add the X11 plumbing

BUG=450899
TEST=Manual, see bug
[email protected]
TBR=pkotwicz

Review URL: https://codereview.chromium.org/889403003

Cr-Commit-Position: refs/heads/master@{#314400}
(cherry picked from commit b726eb1)

Review URL: https://codereview.chromium.org/899323002

Cr-Commit-Position: refs/branch-heads/2272@{#226}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Apr 30, 2015
Autocomplete - Don't store fields we've identified as CVC.
f6c4fc2 
It's possible Chrome will fail to identify a CVC field, and then Autocomplete will save the value. It's not easy to tell if something is a cvc just by looking at it (3 or 4 numerical digits could be anything).

BUG=479374

Review URL: https://codereview.chromium.org/1060863005
[email protected]

Cr-Commit-Position: refs/heads/master@{#326615}
(cherry picked from commit 7d53857)

Review URL: https://codereview.chromium.org/1067863009

Cr-Commit-Position: refs/branch-heads/2357@{#226}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco pushed a commit that referenced this pull request Aug 13, 2015
Do not expire permission bubbles for in-page navigations.
72d49df 
When the IN_PAGE classification was removed in r337562, such navigations were folded into EXISTING_PAGE. The PermissionBubbleManager was checking for EXISTING_PAGE with the understanding that it did not include in-page navigations; restore that understanding.

BUG=516309
TEST=as in bug

Review URL: https://codereview.chromium.org/1266003004

(cherry picked from commit 4e2c120)

Cr-Original-Commit-Position: refs/heads/master@{#341554}
Cr-Commit-Position: refs/branch-heads/2454@{#226}
Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
Disable the extension service worker checks that are crashing the ren…
205fcf6 
…derer.

They're triggering for hosted apps, which is a bug. It's still not correct and
that will be fixed soon, but in the meantime don't crash.

BUG=525965, 529516
[email protected]
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1328313002

Cr-Commit-Position: refs/heads/master@{#347859}
(cherry picked from commit 881d73a)

Review URL: https://codereview.chromium.org/1336643002

Cr-Commit-Position: refs/branch-heads/2490@{#226}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
Reset data usage load status when pref is turned off.
9bef822 
Reset current data usage load status when pref
kDataUsageReportingEnabled is cleared. Without this cl, once
data usage recording has been switched on, it will continue
to be recorded even after the pref is switched off.
BUG=563723

Review URL: https://codereview.chromium.org/1484993002

Cr-Commit-Position: refs/heads/master@{#362556}
(cherry picked from commit e6971d8)

Review URL: https://codereview.chromium.org/1500863002 .

Cr-Commit-Position: refs/branch-heads/2564@{#226}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
@joedow-42
Fix status bar visibility issue on pre-Marshmallow devices
a7f6940 
When the OSK is dismissed on Marshmallow, the OS will call
onSystemUiVisibilityChange which will hide any remaining system UI such
as the status or navigation bar.

On pre-marshallow OSes this method is not called if the user has
interacted with the system UI (such as pulling the notification UI
down).  When this occurs, the user is left in a state where the system
UI acts 'sticky', that is all user interactions are directed to the
system UI instead of our app.

This change will manually hide the system UI on older OSes to prevent
this issue from occurring.

BUG=581931

Review URL: https://codereview.chromium.org/1643273002

Cr-Commit-Position: refs/heads/master@{#372404}
(cherry picked from commit 1771a0d)

Review URL: https://codereview.chromium.org/1657943003 .

Cr-Commit-Position: refs/branch-heads/2623@{#226}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
customtabs: Don't drop a prerender when only the fragment differs.
d69a77f 
BUG=574864

Review URL: https://codereview.chromium.org/1684513006

Cr-Commit-Position: refs/heads/master@{#379833}
[email protected]

Review URL: https://codereview.chromium.org/1800853002 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#226}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
cc : Fix hit testing bug in resourceless software draw mode
bb87ede 
Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.

BUG=614438, 604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2033163003
Cr-Commit-Position: refs/heads/master@{#397543}
(cherry picked from commit 8d0064f)

Review URL: https://codereview.chromium.org/2042573002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#226}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
@csharrison
Popup metrics: Add metrics for popup engagement
f67661f 
This patch adds visibility tracking to the PopupTracker, and it logs
the duration a popup is visible from its first navigation commit until
that document is navigated away from (or the web contents is destroyed).

Bug: 762617
Change-Id: I538712c4f31e8335521da1a283852ef8db3b138d
Reviewed-on: https://chromium-review.googlesource.com/656198
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Charlie Harrison <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#501047}(cherry picked from commit b614fd5)
Reviewed-on: https://chromium-review.googlesource.com/667541
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#226}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakuco @crosswalk-trybot